-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Assistant: Remove autofocus on extended blocks while previewing #39216
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well as far as I can tell.
@monsieur-z you know a lot more about the issue, can you please take a look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked fine for me, code looks good
Merged to avoid a conflict with another PR. @monsieur-z, let me know if you think something else needs to be changed. |
…39216) * remove autofocus on preview blocks * changelog
Fixes #39144
Proposed changes:
isSelectionEnabled
value to determine if autofocus should happen or notThe issue is caused by autofocus happening within the preview block. We want to keep the behavior on blocks added to the editor, but not for preview blocks.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Peek.2024-09-03.19-08.mp4
Peek.2024-09-03.19-09.mp4