Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Assistant: Remove autofocus on extended blocks while previewing #39216

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Sep 3, 2024

Fixes #39144

Proposed changes:

  • Uses the extended blocks' isSelectionEnabled value to determine if autofocus should happen or not

The issue is caused by autofocus happening within the preview block. We want to keep the behavior on blocks added to the editor, but not for preview blocks.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Test using Firefox
  • Go to the block editor
  • Open the block inserter in the sidebar (The + button on the top left, after the site logo)
  • Type "contact form"
  • Check that the block inserter works as expected and the search input is not unfocused
  • In the editor, add a Form block
  • Check that the input is focused immediately
  • Add a paragraph
  • On the paragraph's block toolbar, click on the AI icon > "Ask AI Assistant"
  • Check that the input is focused as well
Before After
Peek.2024-09-03.19-08.mp4
Peek.2024-09-03.19-09.mp4

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/jetpack-ai-preview-focus branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/jetpack-ai-preview-focus
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@sergeymitr sergeymitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well as far as I can tell.
@monsieur-z you know a lot more about the issue, can you please take a look as well.

Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me, code looks good

@dhasilva dhasilva merged commit d15e314 into trunk Sep 4, 2024
59 of 60 checks passed
@dhasilva dhasilva deleted the fix/jetpack-ai-preview-focus branch September 4, 2024 21:07
@dhasilva
Copy link
Contributor Author

dhasilva commented Sep 4, 2024

Merged to avoid a conflict with another PR. @monsieur-z, let me know if you think something else needs to be changed.

@github-actions github-actions bot added this to the jetpack/13.9 milestone Sep 4, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [Extension] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Form makes "Block Inserter" disappear in Firefox
3 participants