Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Stories block (part 4): error handling #17458

Merged
merged 22 commits into from
Oct 22, 2020
Merged

Mobile Stories block (part 4): error handling #17458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7022a2d
Revert "Revert "added new component StoryUpdateProgress", not belongi…
mzorz Sep 21, 2020
af32096
added mediaSave statuses listeners definitions
mzorz Sep 24, 2020
eb6908f
moved StoryEdit to a React.Component class and implemented StoryUpdat…
mzorz Sep 25, 2020
f3b6316
added onStorySaveResult handling to Story block
mzorz Sep 25, 2020
d4d4f91
edit mode: replacing urls by id for saving process
mzorz Sep 28, 2020
cd93dd8
added onMediaModelCreated() callback so we can re-assign the mediaID …
mzorz Sep 28, 2020
6b0addc
update the mediaFile id and URL of a given story frame when finished …
mzorz Sep 29, 2020
92d04e1
removed commented imports
mzorz Sep 29, 2020
a0d35ff
added explicit TODO comments to make sure to follow up on them for er…
mzorz Sep 30, 2020
3f9c638
make sure to call mediaUploadSync and storySaveSync if any of the med…
mzorz Oct 1, 2020
645fa9c
fixed merge conflict
mzorz Oct 1, 2020
5e255c4
Merge branch 'try/jetpack-stories-block-mobile' into try/jetpack-stor…
mzorz Oct 9, 2020
e9e6757
using BlockMediaUpdateProgress
mzorz Oct 10, 2020
b30589f
method rename
mzorz Oct 10, 2020
766ce49
updated story block to represent error state
mzorz Oct 11, 2020
5b613c0
added cancel and retry bridge methods specific for mediaFiles collect…
mzorz Oct 12, 2020
333b06f
using a deep copy of mediaFiles when replacing ids and mediaUrl, give…
mzorz Oct 12, 2020
15fe14e
added requestMediaFilesSaveCancelDialog bridge method
mzorz Oct 12, 2020
f30449c
changed props name onMediaModelCreated to more generic onMediaIdChanged
mzorz Oct 13, 2020
51134e4
removed commented code
mzorz Oct 14, 2020
caea14f
fixed merge conflicts
mzorz Oct 16, 2020
b885029
replaced for loops with map
mzorz Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion extensions/blocks/contact-info/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@ const TEMPLATE = [ [ 'jetpack/email' ], [ 'jetpack/phone' ], [ 'jetpack/address'
const ContactInfoEdit = () => {
return (
<View style={ styles.jetpackContactInfoBlock }>
<InnerBlocks allowedBlocks={ ALLOWED_BLOCKS } templateLock={ false } templateInsertUpdatesSelection={ false } template={ TEMPLATE } />
<InnerBlocks
allowedBlocks={ ALLOWED_BLOCKS }
templateLock={ false }
templateInsertUpdatesSelection={ false }
template={ TEMPLATE }
/>
</View>
);
};
Expand Down
Loading