-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe block: Hide social followers toggle when showSubscribersTotal is not on or isPublicizeEnabled is false #28944
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e2b3533
Don't show "Include social followers in count" when showSubscribersTo…
TimBroddin a300a83
Don't show "Include social followers in count" when showSubscribersTo…
TimBroddin ccb0b2a
Merge branch 'trunk' into fix/subscription-block-toggles
TimBroddin a1e270a
Mock scss imports in jest
glendaviesnz 9a461a3
Fix linting issues
glendaviesnz b83b623
Mock @wordpress/notices
TimBroddin 566c540
Merge branch 'trunk' into fix/subscription-block-toggles
TimBroddin f1baa30
Merge branch 'trunk' into fix/subscription-block-toggles
TimBroddin abf6326
Mock @wordpress/notices in the tests
TimBroddin 2058fe1
Merge remote-tracking branch 'origin/trunk' into fix/subscription-blo…
kraftbj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
projects/plugins/jetpack/changelog/subscription-block-social-toggle
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: bugfix | ||
|
||
Don't show "Include social followers in count" when showSubscribersTotal is not toggled or isPublicizeEnabled is false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work for published posts on simple sites with a free plan because
isPublicizeEnabled
is more like a local state whether sharing is enabled for the post or not. For published posts, this flag isfalse
if re-sharing is not enabled. For simple sites, resharing is not enabled with free plan.You can check its source in
usePublicizeConfig
.The correct solution here might to check if
publicize
module is active.CC: @jeherve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may indeed be a better solution, and we now have
useModuleStatus
to help with that. @Automattic/zap Is that something you could look into?Thank you!