Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert E2E infrastructure to ESM #33846

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Convert E2E infrastructure to ESM #33846

merged 4 commits into from
Nov 7, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Oct 27, 2023

Proposed changes:

Playwright uses a Nodejs loader hook, and the combination of that hook and changes in Node 20 results in several bugs when it comes to loading CommonJS files. It's not even clear whether the bugs are in Playwright or Node.

On the other hand, we can avoid all the bugs (whoever they belong to) by converting everything over to ESM syntax. So let's do that.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Are the E2E tests as happy as they were before?

@anomiex
Convert E2E infrastructure to ESM
8d87f7f 
Playwright uses a Nodejs loader hook, and the combination of that hook
and changes in Node 20 results in several bugs when it comes to loading
CommonJS files. It's not even clear whether the bugs are in Playwright
or Node.

On the other hand, we can avoid all the bugs (whoever they belong to) by
converting everything over to ESM syntax. So let's do that.
@anomiex anomiex self-assigned this Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/convert-e2e-tests-to-esm branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/convert-e2e-tests-to-esm

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Action] Test Results to Slack [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tests] Includes Tests Actions GitHub actions used to automate some of the work around releases and repository management Docs E2E Tests labels Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Migration plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Oct 27, 2023
@anomiex anomiex requested review from jeherve, adimoldovan and a team October 31, 2023 15:59
@zinigor
Copy link
Member

zinigor commented Nov 2, 2023

It looks like some E2E tests are failing with module imports, and others are timing out, so probably something related to that a well.

@anomiex
Copy link
Contributor Author

anomiex commented Nov 2, 2023

We have a few known E2E issues at the moment

Paypal block failure should be fixed in with a trunk merge (#33889). Hopefully #33783 will also help with the timeouts. I'll do that merge once I finish up some other stuff.

@anomiex
Copy link
Contributor Author

anomiex commented Nov 2, 2023

E2E failures look like just the known issues mentioned above.

@anomiex anomiex enabled auto-merge (squash) November 2, 2023 19:59
@anomiex
Copy link
Contributor Author

anomiex commented Nov 6, 2023

Boost lazy-image PR was merged and included in the latest trunk merge. The one failure this time around is the known MailChimp issue.

@anomiex
Copy link
Contributor Author

anomiex commented Nov 7, 2023

Hmm. I may have managed to fix the MailChimp test by just reconnecting the test account. At least it worked locally, let's see if it works here too.

sdixon194
sdixon194 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are happy! Let's do it!

@anomiex anomiex merged commit 278ba7f into trunk Nov 7, 2023
64 checks passed
@anomiex anomiex deleted the update/convert-e2e-tests-to-esm branch November 7, 2023 19:19
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 7, 2023
@anomiex anomiex mentioned this pull request Nov 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

@jeherve jeherve Awaiting requested review from jeherve

@adimoldovan adimoldovan Awaiting requested review from adimoldovan

Assignees

@anomiex anomiex

Labels
[Action] Test Results to Slack Actions GitHub actions used to automate some of the work around releases and repository management Docs E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal [Tests] Includes Tests [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anomiex @zinigor @sdixon194