Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection: improve connection info for multidomain setups #33857

Closed
wants to merge 1 commit into from

Conversation

bindlegirl
Copy link
Contributor

@bindlegirl bindlegirl commented Oct 30, 2023

Add connection information for multidomain sites.

Currently, I added these changes to My Jetpack.

Multidomain site when accessing My Jetpack from a secondary domain:
Screenshot 2023-10-30 at 11 22 08

My Jetpack when site is in Safe Mode:
Screenshot 2023-10-30 at 13 07 44

Proposed changes:

  • Check the primay connected domain and compare it to the currently used one.
  • If not in IDC, display information about the primary domain.
  • Sites with only one domain will see no difference.
  • Add Safe Mode notification to My Jetpack connection card.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • You need a site that's using two domains (JT site can be used).
  • Use one domain to create the connection. Check the Connection card on My Jetpack page. It should look same as it does before applying this branch.
  • Access My Jetpack using the secondary domain. It should look as in screenshot above.

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/multidomain-cxn-info branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/multidomain-cxn-info
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@sergeymitr sergeymitr self-requested a review October 30, 2023 16:34
@bindlegirl bindlegirl added the DO NOT MERGE don't merge it! label Oct 31, 2023
Copy link
Contributor

This PR has been marked as stale. This happened because:

  • It has been inactive for the past 3 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

@bindlegirl bindlegirl force-pushed the add/multidomain-cxn-info branch from 1b51747 to 876ae1f Compare February 2, 2024 18:18
@bindlegirl bindlegirl added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] In Progress and removed DO NOT MERGE don't merge it! [Status] Stale [Status] In Progress [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 2, 2024
@bindlegirl
Copy link
Contributor Author

After merging other planned changes to IDC and looking at logs, this doesn't seem like a good idea anymore. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant