Sitemaps: Fix the Hook from init to wp_loaded for Sitemap URL handler.

[rutviksavsani]

Fixes #

Proposed changes:

• This PR proposes to generate the permalinks on the wp_loaded hook instead of the init hook which would allow us to get all our plugins and theme changes loaded and the modified permalinks being generated properly.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Steps to reproduce:

1. Setup a sitemap with active Jetpack and Sitemaps active.
2. Upload this plugin which registers a custom post type at a priority of 11 and adds it to the News Sitemap.
   Plugin gist link : https://gist.github.com/rutviksavsani/4cd931d72a981b637a2b3d745ca5c359
3. Add a new post to the Artist post-type.
4. Now on checking the URL of the post on the News post-type, You should be able to see a raw URL and not a final Permalink.
5. Now when applying this PR, we should be able to see the correct URLs as we wait for all the plugins and theme actions to get registered. ( Note: Make sure to delete old Transient for new links to be showed. )

Video for reproducing:

video-22820443-4c9fe126.mp4

Screenshots:

Before:

After:

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[monsieur-z]

It looks like a fair change to me. @nbloomf, it's been a while since you worked on sitemaps but you might have some feedback to share. Any possible unwanted side effects?

[monsieur-z]

Works as advertised 👍

[monsieur-z]

A trunk rebase/merge is required.

[rutviksavsani]

Rebase done.