Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDC: old code cleanup #35048

Merged
merged 6 commits into from
Feb 6, 2024
Merged

IDC: old code cleanup #35048

merged 6 commits into from
Feb 6, 2024

Conversation

bindlegirl
Copy link
Contributor

@bindlegirl bindlegirl commented Jan 15, 2024 •
edited
Loading

Old code cleanup

Proposed changes:

  • Deleting previously deprecated methods.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Create a test site and run standard IDC tests. Everything should work
  • To test, you can use two JN sites and the Jetpack Debug tools. Use the tool to swap blog id on one of the sites with the ide from the other one. Safe mode should appear and all options should work (start fresh or migrate)

@bindlegirl bindlegirl added [Focus] Performance [Status] In Progress IDC [Pri] Normal [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Maintenance labels Jan 15, 2024
@bindlegirl bindlegirl self-assigned this Jan 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/deprecate-delete-idc-code branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/deprecate-delete-idc-code

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. label Jan 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Migration plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@bindlegirl bindlegirl force-pushed the update/deprecate-delete-idc-code branch from 7876c98 to 4d2557b Compare February 2, 2024 16:39
@bindlegirl bindlegirl force-pushed the update/deprecate-delete-idc-code branch from 4d2557b to 7e1a046 Compare February 2, 2024 17:15
@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Feb 2, 2024
@bindlegirl bindlegirl requested a review from sergeymitr February 2, 2024 17:18
@bindlegirl bindlegirl added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Feb 2, 2024
@bindlegirl bindlegirl added this to the jetpack/13.1 milestone Feb 2, 2024
@bindlegirl bindlegirl enabled auto-merge (squash) February 2, 2024 22:37
@samiff samiff modified the milestones: jetpack/13.1, jetpack/13.2 Feb 5, 2024
@sergeymitr
Copy link
Contributor

Hi @bindlegirl.
Everything looks good and tests well.

There also are a few render_* methods (e.g. render_notice_first_step()) which weren't marked as deprecated at the time, but are only called by the deprecated ones, so I believe they are safe to remove as well.

@bindlegirl
Copy link
Contributor Author

@sergeymitr Thanks for checking the PR. I addressed those other methods in #35444 This one is just about deleting the stuff that was deprecated before. The other PR is deprecating unused methods.
I felt it could be a bit hard to read if I put everything in one PR

@bindlegirl bindlegirl merged commit 9c08613 into trunk Feb 6, 2024
66 checks passed
@bindlegirl bindlegirl deleted the update/deprecate-delete-idc-code branch February 6, 2024 15:38
@sergeymitr
Copy link
Contributor

@bindlegirl that makes sense.
Thanks for cleaning up this old stuff!

@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 6, 2024
spsiddarthan pushed a commit that referenced this pull request Feb 15, 2024
@bindlegirl @spsiddarthan
IDC: old code cleanup (#35048)
b5331b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeymitr sergeymitr sergeymitr approved these changes

Assignees

@bindlegirl bindlegirl

Labels
[Focus] Performance IDC [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal [Tests] Includes Tests
Projects
None yet
Milestone
jetpack/13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bindlegirl @sergeymitr @samiff