Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User invitation: Mail the newly added user with WPCom invite #35234

Merged
merged 14 commits into from
Jan 29, 2024
Merged

User invitation: Mail the newly added user with WPCom invite #35234

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b4ad76f
Initial implementation of email invitation
renancarvalho Jan 24, 2024
468a62e
Initial implementation of email invitation
renancarvalho Jan 24, 2024
c2c9d1e
changelog
renancarvalho Jan 24, 2024
0afde6d
Finishing api call
renancarvalho Jan 25, 2024
9e805f2
Update improve_invite_form
renancarvalho Jan 25, 2024
871b50d
Update changelog
renancarvalho Jan 25, 2024
7174dcf
Improve user role param
renancarvalho Jan 25, 2024
c4891d3
Handle errors
renancarvalho Jan 26, 2024
a3a82ff
Use notice to render message
renancarvalho Jan 26, 2024
a0b248d
Add admin create user stylesheets
renancarvalho Jan 26, 2024
8ec6cab
Merge branch 'add/sso-improvements' into improve_invite_form
alshakero Jan 26, 2024
f08d7f4
Hide unnecessary TR
renancarvalho Jan 27, 2024
4bd8644
Add link to sso page
renancarvalho Jan 27, 2024
1c3e8bc
Fix translation
renancarvalho Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/improve_invite_form
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

SSO: When creating a new users, mail the users with an invitation to WPCom.
147 changes: 111 additions & 36 deletions projects/plugins/jetpack/modules/sso.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ private function __construct() {
add_action( 'jetpack_site_before_disconnected', array( static::class, 'disconnect' ) );
add_action( 'wp_login', array( 'Jetpack_SSO', 'clear_cookies_after_login' ) );

// If the user has no errors on creation, send an invite to WordPress.com.
add_filter( 'user_profile_update_errors', array( $this, 'send_wpcom_mail_user_invite' ), 10, 3 );
// Don't send core invitation email when SSO is activated. They will get an email from WP.com.
add_filter( 'wp_send_new_user_notification_to_user', '__return_false' );
add_action( 'user_new_form', array( $this, 'render_invitation_email_message' ) );

// Adding this action so that on login_init, the action won't be sanitized out of the $action global.
add_action( 'login_form_jetpack-sso', '__return_true' );

Expand Down Expand Up @@ -206,6 +212,75 @@ public function create_error_notice_and_redirect( $query_params ) {
return wp_safe_redirect( $url );
}

/**
* Render the invitation email message.
*/
public function render_invitation_email_message() {
// Enqueue the CSS for the admin create user page.
wp_enqueue_style( 'jetpack-sso-admin-create-user', plugins_url( 'modules/sso/jetpack-sso-admin-create-user.css', JETPACK__PLUGIN_FILE ), array(), time() );

$message = sprintf(
'%s<a class="%s" rel="noopener noreferrer" target="_blank" href="%s">%s</a>',
__( 'New users will receive an invite to join WordPress.com, so they can log in securely using', 'jetpack' ),
'jetpack-sso-admin-create-user-invite-message-link-sso',
esc_url( 'https://jetpack.com/support/sso/' ),
__( 'Secure Sign On.', 'jetpack' )
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great, a few notes:

  • Let's use %1$s, %2$s, %3$s instead, to have more clarity.
  • After that let's add the * translators: %1$s is the message, %2$2 is ....

wp_admin_notice(
$message,
array(
'id' => 'invitation_message',
'type' => 'info',
'dismissible' => false,
'additional_classes' => array( 'jetpack-sso-admin-create-user-invite-message' ),
)
);
}

/**
* Send user invitation to WordPress.com if user has no errors.
*
* @param WP_Error $errors The WP_Error object.
* @param bool $update Whether the user is being updated or not.
* @param stdClass $user The User object about to be created.
* @return WP_Error The modified or not WP_Error object.
*/
public function send_wpcom_mail_user_invite( $errors, $update, $user ) {

if ( $errors->has_errors() ) {
return $errors;
}

$email = $user->user_email;
$role = $user->role;
$locale = get_user_locale( $user->ID );
$blog_id = Jetpack_Options::get_option( 'id' );
$url = '/sites/' . $blog_id . '/invites/new';
$url = add_query_arg( 'locale', $locale, $url );

$response = Client::wpcom_json_api_request_as_user(
$url,
'2', // Api version
array(
'method' => 'POST',
),
array(
'invitees' => array(
array(
'email_or_username' => $email,
'role' => $role,
),
),
)
);

if ( 200 !== $response['response']['code'] ) {
$errors->add( 'invitation_not_sent', __( '<strong>Error</strong>: "The user invitation email could not be sent, the user account was not created.', 'jetpack' ) );
}

return $errors;
}

/**
* Returns the single instance of the Jetpack_SSO object
*
Expand Down Expand Up @@ -372,7 +447,7 @@ public function sso_reminder_logout_wpcom( $errors ) {
if ( ! empty( $errors->errors['loggedout'] ) ) {
$logout_message = wp_kses(
sprintf(
/* translators: %1$s is a link to the WordPress.com account settings page. */
/* translators: %1$s is a link to the WordPress.com account settings page. */
__( 'If you are on a shared computer, remember to also <a href="%1$s">log out of WordPress.com</a>.', 'jetpack' ),
'https://wordpress.com/me'
),
Expand Down Expand Up @@ -573,8 +648,8 @@ public function render_require_two_step() {
<input
type="checkbox"
name="jetpack_sso_require_two_step"
<?php checked( Jetpack_SSO_Helpers::is_two_step_required() ); ?>
<?php disabled( Jetpack_SSO_Helpers::is_require_two_step_checkbox_disabled() ); ?>
<?php checked( Jetpack_SSO_Helpers::is_two_step_required() ); ?>
<?php disabled( Jetpack_SSO_Helpers::is_require_two_step_checkbox_disabled() ); ?>
>
<?php esc_html_e( 'Require Two-Step Authentication', 'jetpack' ); ?>
</label>
Expand Down Expand Up @@ -605,10 +680,10 @@ public function render_match_by_email() {
<input
type="checkbox"
name="jetpack_sso_match_by_email"
<?php checked( Jetpack_SSO_Helpers::match_by_email() ); ?>
<?php disabled( Jetpack_SSO_Helpers::is_match_by_email_checkbox_disabled() ); ?>
<?php checked( Jetpack_SSO_Helpers::match_by_email() ); ?>
<?php disabled( Jetpack_SSO_Helpers::is_match_by_email_checkbox_disabled() ); ?>
>
<?php esc_html_e( 'Match by Email', 'jetpack' ); ?>
<?php esc_html_e( 'Match by Email', 'jetpack' ); ?>
</label>
<?php
}
Expand Down Expand Up @@ -802,32 +877,32 @@ public function login_form() {
?>
<div id="jetpack-sso-wrap">
<?php
/**
* Allow extension above Jetpack's SSO form.
*
* @module sso
*
* @since 8.6.0
*/
do_action( 'jetpack_sso_login_form_above_wpcom' );
/**
* Allow extension above Jetpack's SSO form.
*
* @module sso
*
* @since 8.6.0
*/
do_action( 'jetpack_sso_login_form_above_wpcom' );

if ( $display_name && $gravatar ) :
?>
<div id="jetpack-sso-wrap__user">
<img width="72" height="72" src="<?php echo esc_html( $gravatar ); ?>" />

<h2>
<?php
echo wp_kses(
/* translators: %s a user display name. */
sprintf( __( 'Log in as <span>%s</span>', 'jetpack' ), esc_html( $display_name ) ),
array( 'span' => true )
);
?>
<?php
echo wp_kses(
/* translators: %s a user display name. */
sprintf( __( 'Log in as <span>%s</span>', 'jetpack' ), esc_html( $display_name ) ),
array( 'span' => true )
);
?>
</h2>
</div>

<?php endif; ?>
<?php endif; ?>


<div id="jetpack-sso-wrap__action">
Expand Down Expand Up @@ -863,18 +938,18 @@ public function login_form() {
<?php endif; ?>
</div>

<?php
/**
* Allow extension below Jetpack's SSO form.
*
* @module sso
*
* @since 8.6.0
*/
do_action( 'jetpack_sso_login_form_below_wpcom' );

if ( ! Jetpack_SSO_Helpers::should_hide_login_form() ) :
?>
<?php
/**
* Allow extension below Jetpack's SSO form.
*
* @module sso
*
* @since 8.6.0
*/
do_action( 'jetpack_sso_login_form_below_wpcom' );

if ( ! Jetpack_SSO_Helpers::should_hide_login_form() ) :
?>
<div class="jetpack-sso-or">
<span><?php esc_html_e( 'Or', 'jetpack' ); ?></span>
</div>
Expand All @@ -890,9 +965,9 @@ public function login_form() {
esc_html_e( 'Log in with WordPress.com', 'jetpack' )
?>
</a>
<?php endif; ?>
<?php endif; ?>
</div>
<?php
<?php
}

/**
Expand Down
12 changes: 12 additions & 0 deletions projects/plugins/jetpack/modules/sso/jetpack-sso-admin-create-user.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

.jetpack-sso-admin-create-user-invite-message {
width: 550px;
}
/* Hide the checkbox to send WP core invitation emails when SSO is on */
#createuser .form-table tr:has( #send_user_notification ) {
display: none;
}
.jetpack-sso-admin-create-user-invite-message-link-sso {
margin-left: 3px;
text-decoration: none;
}
1 change: 1 addition & 0 deletions projects/plugins/jetpack/tools/webpack.config.css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ for ( const name of [
'modules/widget-visibility/widget-conditions/widget-conditions',
'modules/widgets/gallery/css/admin',
'modules/sso/jetpack-sso-login',
'modules/sso/jetpack-sso-admin-create-user',
'modules/masterbar/admin-menu/admin-menu',
'modules/masterbar/admin-menu/admin-menu-nav-unification',
] ) {
Expand Down
Loading