Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: Use node20 runner #35262

Merged
merged 1 commit into from
Jan 26, 2024
Merged

actions: Use node20 runner #35262

merged 1 commit into from
Jan 26, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 25, 2024

Proposed changes:

GitHub has deprecated the node16 runner in favor of node20. https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Thus, we need to make some updates:

  • Update our actions to use the node20 runner.
  • Update workflows to use new versions of various actions:
    • actions/cache v3 → v4
    • actions/setup-node v3 → v4
    • actions/github-script v6 → v7
    • actions/setup-node v3 → v4
    • actions/stale v8 → v9
    • github/codeql-action v2 → v3
    • peter-evans/repository-dispatch v2 → v3
  • Update references to the above in some docs.
  • Remove a long-commented-out job in gardening.yml

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is CI happy?
  • For the rest, merge and observe.

GitHub has deprecated the node16 runner in favor of node20.
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Thus, we need to make some updates:
* Update our actions to use the node20 runner.
* Update workflows to use new versions of various actions:
  - actions/cache v3 → v4
  - actions/setup-node v3 → v4
  - actions/github-script v6 → v7
  - actions/setup-node v3 → v4
  - actions/stale v8 → v9
  - github/codeql-action v2 → v3
  - peter-evans/repository-dispatch v2 → v3
* Update references to the above in some docs.
* Remove a long-commented-out job in gardening.yml
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jan 25, 2024
@anomiex anomiex requested a review from a team January 25, 2024 21:19
@anomiex anomiex self-assigned this Jan 25, 2024
@anomiex anomiex enabled auto-merge (squash) January 25, 2024 21:19
@anomiex anomiex disabled auto-merge January 25, 2024 21:19
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/actions-node20 branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/actions-node20
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/actions-node20
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Action] Push To Mirrors Action to push folders of a monorepo to a mirror repo [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project [Action] Required Review [Action] Test Results to Slack Actions GitHub actions used to automate some of the work around releases and repository management Docs labels Jan 25, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@zinigor zinigor enabled auto-merge (squash) January 26, 2024 13:39
@zinigor zinigor merged commit ccb390e into trunk Jan 26, 2024
69 checks passed
@zinigor zinigor deleted the update/actions-node20 branch January 26, 2024 13:39
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Push To Mirrors Action to push folders of a monorepo to a mirror repo [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project [Action] Required Review [Action] Test Results to Slack Actions GitHub actions used to automate some of the work around releases and repository management Docs [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants