SSO improvements main PR #35277

alshakero · 2024-01-26T13:42:02Z

This is the main PR towards SSO improvements. It's a place to merge PRs into, please do not push anything to it that is not updating it against trunk.

Proposed changes:

Includes the following PRs:

Summary:

Site owners now have a much better experience managing users.

Different colors for users connected, not invited or with a pending invite to join WordPress.com
Possibility to quick send an invite to a user
Possibility to revoke an invitation
When adding a new user we now have a custom message sent, a notice that shows to the site owner that an invitation will be sent. And when the user is created, we send a WordPress.com invitation.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Design/Kick-off thread: pdDR7T-1jU-p2
Project proposal / feedback requested thread: pdDR7T-1ja-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

Sync the Jetpack plugin to your site.
Check that the summary changes are reflected.
Try to break this.
Check how it is on mobile.

github-actions · 2024-01-26T13:43:12Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Co-authored-by: Anthony Grullon <[email protected]>

github-actions · 2024-01-26T16:50:30Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/sso-improvements branch.
To test on Simple, run the following command on your sandbox:
```
bin/jetpack-downloader test jetpack add/sso-improvements
```

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

* Initial implementation of email invitation * Initial implementation of email invitation * changelog * Finishing api call * Update improve_invite_form * Update changelog * Improve user role param * Handle errors * Use notice to render message * Add admin create user stylesheets * Hide unnecessary TR * Add link to sso page * Fix translation --------- Co-authored-by: Omar Alshaker <[email protected]>

* Fix translation * Add changelog * Add wp_kses

Co-authored-by: Omar Alshaker <[email protected]>

Co-authored-by: Anthony Grullon <[email protected]>

jeherve · 2024-01-30T07:36:52Z

Is there a p2 post where I could find out more about this project? I'm curious what y'all have in mind for this feature :)

agrullon95 · 2024-01-31T22:38:39Z

Is there a p2 post where I could find out more about this project? I'm curious what y'all have in mind for this feature :)

@jeherve - You can read more about this project here:

Design/Kick-off thread: pdDR7T-1jU-p2
Project proposal / feedback requested thread: pdDR7T-1ja-p2

jeherve · 2024-02-01T08:27:51Z

Thank you!

Co-authored-by: Omar Alshaker <[email protected]>

heavyweight · 2024-02-06T10:30:53Z

projects/plugins/jetpack/modules/sso.php

+	public function render_invitation_email_message() {
+		$message = wp_kses(
+			__(
+				'New users will receive an invite to join WordPress.com, so they can log in securely using <a class="jetpack-sso-admin-create-user-invite-message-link-sso" rel="noopener noreferrer" target="_blank" href="https://jetpack.com/support/sso/">Secure Sign On</a>.',


Minor whine, but we could improve this to return support documentation based on the user's locale. For example https://jetpack.com/es/support/sso/ for spanish users

heavyweight · 2024-02-06T10:57:22Z

Screen.Recording.2024-02-06.at.11.53.11.mov

Created a new admin, visited the invitation link, and created my wp.com account. After that, I got redirected to the admin ui where I had that weird state as in the video. After logging in with wp.com again it got fixed.

To reproduce you will probably need to enable the classic admin setting in https://wpcalypso.wordpress.com/

Edit @alshakero: this issue is documented 5158-gh-Automattic/dotcom-forge.

* Add SSO status column and tooltip * add changelog

* Improve question mark icon * Add changelog

Co-authored-by: Anthony Grullon <[email protected]>

…into add/sso-improvements

heavyweight

Re-tested and didn't find any issues

renancarvalho

Tested and did not locate any issues as well, I think we are good to go! 👍

Initial

78267d8

alshakero changed the title ~~Initial~~ SSO improvements main PR Jan 26, 2024

github-actions bot added [Status] In Progress Docs labels Jan 26, 2024

SSO: Implement users table improvements (#35158)

020ecdf

Co-authored-by: Anthony Grullon <[email protected]>

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 26, 2024

github-actions bot added the [Feature] SSO label Jan 29, 2024

renancarvalho and others added 4 commits January 29, 2024 17:01

Invite user message: Fix translation (#35304)

58b0a7c

* Fix translation * Add changelog * Add wp_kses

SSO: Add revoke invite action to users table (#35282)

4943ea7

Co-authored-by: Omar Alshaker <[email protected]>

SSO: Apply design feedback to table (#35298)

a7a6d64

Co-authored-by: Anthony Grullon <[email protected]>

Merge branch 'trunk' into add/sso-improvements

814c559

alshakero and others added 3 commits February 2, 2024 17:58

Merge branch 'trunk' into add/sso-improvements

a20834a

SSO: Add custom message to new user email (#35395)

f34f2a6

Co-authored-by: Omar Alshaker <[email protected]>

Merge branch 'trunk' into add/sso-improvements

6420ce8

escapemanuele requested review from renancarvalho, heavyweight and agrullon95 February 6, 2024 09:31

escapemanuele marked this pull request as ready for review February 6, 2024 09:42

heavyweight reviewed Feb 6, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

heavyweight and others added 19 commits February 9, 2024 14:38

Cleanup unused locale

3dcb679

SSO: Users page, change column text and add tooltip (#35572)

1ed8a69

* Add SSO status column and tooltip * add changelog

Merge branch 'trunk' into add/sso-improvements

c798ec9

SSO/Improve row readability: Add icon and rename row item (#35573)

eb087f8

SSO: Move user related customisation to separate file (#35617)

2841aee

SSO: Improve question mark icon (#35682)

7af8f14

* Improve question mark icon * Add changelog

Invite: Change param name (#35684)

2b27d92

Merge branch 'trunk' into add/sso-improvements

c9b1e07

SSO: Update users table sso background colors (#35685)

ac4aba7

Add caching for invites (#35675)

3eaeca4

Co-authored-by: Anthony Grullon <[email protected]>

Rename changelog

aeff384

Discard changes to readme.md

3f9bec7

Remove unnecessary return

e73fd96

Merge branch 'add/sso-improvements' of github.com:Automattic/jetpack …

62fa5b0

…into add/sso-improvements

Move clear_wpcom_profile_cookies to sso helpers

d389728

Minor comment fix

e32343d

Add custom message missing translation

43d5566

Merge branch 'trunk' into add/sso-improvements

099a44f

Switch to gray sso icon background

70aab6a

heavyweight approved these changes Feb 16, 2024

View reviewed changes

renancarvalho approved these changes Feb 16, 2024

View reviewed changes

escapemanuele merged commit 898821d into trunk Feb 16, 2024
54 checks passed

escapemanuele deleted the add/sso-improvements branch February 16, 2024 12:41

github-actions bot removed the [Status] In Progress label Feb 16, 2024

github-actions bot added this to the jetpack/13.2 milestone Feb 16, 2024

samiff added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Feb 25, 2024

ice9js restored the add/sso-improvements branch March 21, 2024 15:06

kraftbj mentioned this pull request Mar 22, 2024

Static Analysis: throw error if using a function newly in the latest WP version #36514

Closed

escapemanuele deleted the add/sso-improvements branch March 22, 2024 14:42

escapemanuele restored the add/sso-improvements branch March 22, 2024 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSO improvements main PR #35277

SSO improvements main PR #35277

alshakero commented Jan 26, 2024 •

edited by heavyweight

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

jeherve commented Jan 30, 2024

agrullon95 commented Jan 31, 2024

jeherve commented Feb 1, 2024

heavyweight Feb 6, 2024

This comment was marked as outdated.

heavyweight commented Feb 6, 2024 •

edited by alshakero

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

heavyweight left a comment

renancarvalho left a comment

SSO improvements main PR #35277

SSO improvements main PR #35277

Conversation

alshakero commented Jan 26, 2024 • edited by heavyweight Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 26, 2024 • edited Loading

github-actions bot commented Jan 26, 2024 • edited Loading

jeherve commented Jan 30, 2024

agrullon95 commented Jan 31, 2024

jeherve commented Feb 1, 2024

heavyweight Feb 6, 2024

Choose a reason for hiding this comment

This comment was marked as outdated.

heavyweight commented Feb 6, 2024 • edited by alshakero Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

heavyweight left a comment

Choose a reason for hiding this comment

renancarvalho left a comment

Choose a reason for hiding this comment

alshakero commented Jan 26, 2024 •

edited by heavyweight

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

heavyweight commented Feb 6, 2024 •

edited by alshakero

Loading