Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriber Login: Move Subscriber Login block to production #35332

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

pkuliga
Copy link
Contributor

@pkuliga pkuliga commented Jan 30, 2024

Part of #34884

Proposed changes:

It moves the Subscriber Login block to production.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Make sure the Subscriber Login block is no longer marked as a beta block.

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/subscriber-login-no-longer-beta branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/subscriber-login-no-longer-beta
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@pkuliga pkuliga added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 30, 2024
@jeherve jeherve added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Block] Subscriber Login [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. labels Jan 30, 2024
@jeherve
Copy link
Member

jeherve commented Jan 30, 2024

If we're moving this block to production, would it be possible to let the WordPress.com and Jetpack support teams know, so they can work on the necessary support documents, and so they know what this new block brings to customers?

Thanks!

Also cc'ing @Automattic/jetpack-garage for general awareness for the upcoming release.

@samiff
Copy link
Contributor

samiff commented Jan 30, 2024

Also cc'ing @Automattic/jetpack-garage for general awareness for the upcoming release.

Thanks! For reference the hard cut for Jetpack 13.1 will be on 2024-02-05

Internal testing for Jetpack 13.1 has started this week, so if we want testers to give this a spin, you can either update the testing thread or let me know and I can assist: p8oabR-1qU-p2

@pkuliga pkuliga requested a review from a team January 30, 2024 21:15
@pkuliga
Copy link
Contributor Author

pkuliga commented Jan 30, 2024

Internal testing for Jetpack 13.1 has started this week, so if we want testers to give this a spin, you can either update the testing thread or let me know and I can assist: p8oabR-1qU-p2

Sure, I can do it. By "update the testing thread" you mean adding some testing scenarios below "Jetpack 13.1 Testing Items"?

@pkuliga pkuliga mentioned this pull request Jan 30, 2024
23 tasks
@samiff
Copy link
Contributor

samiff commented Jan 30, 2024

By "update the testing thread" you mean adding some testing scenarios below "Jetpack 13.1 Testing Items"?

Yes! Any steps you think might be helpful in surfacing any bugs in the different testing environments.

@pkuliga
Copy link
Contributor Author

pkuliga commented Jan 30, 2024

Added 😄

p8oabR-1qU-p2#subscriber-login-block

simison
simison previously approved these changes Feb 2, 2024
@simison simison mentioned this pull request Feb 2, 2024
3 tasks
@pkuliga pkuliga merged commit 062e1d9 into trunk Feb 2, 2024
53 of 54 checks passed
@pkuliga pkuliga deleted the update/subscriber-login-no-longer-beta branch February 2, 2024 12:01
@github-actions github-actions bot added this to the jetpack/13.1 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriber Login [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants