Social: Remove the flow to update broken connections directly from the editor.

[spsiddarthan]

Proposed changes:

• The reconnection flow doesn't work well and is broken, when you try to reconnect a broken connection using magic link URLs. See the refresh connection with Facebook bit in the image below. We are going to get rid of that link and instead rely on the second notice we show, so the users re-connect their connections from the connection management screen.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• On trunk, connect a Facebook Jetpack Social connection.
• Go to https://www.facebook.com/settings/?tab=business_tools, and under business integrations remove Facebook.
• Go to Publicize RC and test the Facebook connection. It will be broken.
• Try creating a post and see that in the editor sidebar, you see the magic link to refresh the Facebook connection as shown in the image in the proposed changes section on this PR.
• Checkout this branch and ensure that the magic link section goes away and only the connection management screen notice shows up.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/hide-magic-link-for-connection-refresh branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/hide-magic-link-for-connection-refresh
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[pablinos]

This is working well for me, but I wonder if we should get rid of more code!

[pablinos]

I think this might never be used as all connections are being returned as refreshable (as long as the user is an admin). It also does the same as above and renders the message received from the server, which I don't think we want to happen, because we'll end up with two notices about broken connections.

Should we get rid of this too?

[spsiddarthan]

I have done that, but this leaves <PublicizeConnectionVerify> as a component that returns null in the render function. It's calling the connection-test-results in componentDidMount, but I think there is some scope for refactoring this component and moving the necessary code into the PublicizePanel. Should we do that in a follow-up? Or is there a simple way to do it now?

[pablinos]

Hmmm, good point. It's only used here, so, like you say, maybe we could dispatch the request in a useEffect instead, and get rid of this component altogether.

I think it is ok to have this return null, so we could merge this to make sure it makes the release, and then refactor it.

[pablinos]

Let's refactor this, to something like a custom hook, in a follow-up change