Sharing buttons style improvements #35354

andrii-lysenko · 2024-01-30T22:25:55Z

Fixes #35044

Proposed changes:

Adds color controls to Sharing Buttons block, similar to Social Links in core Gutenberg.

Screen.Recording.2024-01-30.at.2.35.36.PM.mov

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Spin up your site with local changes
Make sure you have beta block enabled. In your environment (example Docker) wp-config.php you should have define( 'JETPACK_BLOCKS_VARIATION', 'beta' );
Add Sharing Buttons block to a post.
Check controls

github-actions · 2024-01-30T22:26:45Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the sharing-buttons-style-improvements branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack sharing-buttons-style-improvements

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-01-30T22:27:00Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

…e-improvements

monsieur-z · 2024-01-31T14:45:32Z

projects/plugins/jetpack/extensions/blocks/sharing-button/edit.js

@@ -21,10 +21,17 @@ const SharingButtonEdit = ( { attributes, context } ) => {
 		className: 'jetpack-sharing-button__list-item',
 	} );

+	const defaultIconColor = styleType === 'icon' ? '#fff' : '#000';
+
+	const buttonStype = {


Minor typo, I believe you meant buttonStyle 😃

Eagle eye 🦅

monsieur-z · 2024-01-31T14:56:40Z

projects/plugins/jetpack/extensions/blocks/sharing-button/edit.js

@@ -21,10 +21,17 @@ const SharingButtonEdit = ( { attributes, context } ) => {
 		className: 'jetpack-sharing-button__list-item',
 	} );

+	const defaultIconColor = styleType === 'icon' ? '#fff' : '#000';


Nitpicking here, but I'm wondering if we can force the white color for icons in CSS rather than here.

For other block styles, I'd say maybe let's inherit the body color instead of using pure black. Discard my comment if that was already discussed.

Thanks for the suggestion. I was too focused on making it work and didn't think of the obvious.

monsieur-z

Tested well! I'm a bit concerned the block could end up with really poor contrast, but at this point I guess it's up to the authors to make sure accessibility standards are respected.
.

I noticed a small error in how attributes are delimited:

See the extra ".

andrii-lysenko · 2024-01-31T15:28:47Z

@monsieur-z Thanks for review. I did refactored a bit to remove empty " ". As per poor contrast, great point, we do have ColorChecker, but it doesn't work with default colors yet. I will create a followup task to cover these as well.

…e-improvements

jeherve

This tests well for me. I have a few suggestions on the markup output, to simplify things a bit and avoid empty tags, but I think I'll merge this now and open a new PR to offer my changes, so folks can start testing things as soon as possible. :)

jeherve · 2024-02-01T11:26:40Z

@andrii-lysenko Here it is: #35390 Let me know what you think about it.

keoshi · 2024-02-01T14:27:30Z

Missed the review, but just wanted to say this looks great!

* add Sharing Buttons color controls * add changelog * fix default colors * fix lint * fix typo * refactor styles * remove unnecessary logic

andrii-lysenko added 2 commits January 30, 2024 14:22

add Sharing Buttons color controls

5bb93c3

add changelog

d584c07

github-actions bot added [Block] Sharing Buttons [Block] Sharing Button [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Jan 30, 2024

andrii-lysenko added 2 commits January 30, 2024 14:34

fix default colors

861bc07

fix lint

4e6b89d

andrii-lysenko added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 30, 2024

andrii-lysenko self-assigned this Jan 30, 2024

andrii-lysenko requested review from ndiego and a team January 30, 2024 22:42

andrii-lysenko marked this pull request as ready for review January 30, 2024 22:42

Merge remote-tracking branch 'origin/trunk' into sharing-buttons-styl…

2c25c85

…e-improvements

monsieur-z reviewed Jan 31, 2024

View reviewed changes

fix typo

682a2fb

monsieur-z reviewed Jan 31, 2024

View reviewed changes

refactor styles

b7a3d09

remove unnecessary logic

57a8418

andrii-lysenko mentioned this pull request Jan 31, 2024

Sharing Block: add ContrastChecker when using default colors #35375

Closed

andrii-lysenko requested a review from keoshi January 31, 2024 17:11

andrii-lysenko mentioned this pull request Jan 31, 2024

Sharing Block: Improve colour style configs #35044

Closed

Merge remote-tracking branch 'origin/trunk' into sharing-buttons-styl…

e06f57d

…e-improvements

andrii-lysenko requested a review from monsieur-z January 31, 2024 18:07

jeherve approved these changes Feb 1, 2024

View reviewed changes

jeherve merged commit cfef7d4 into trunk Feb 1, 2024
55 checks passed

jeherve deleted the sharing-buttons-style-improvements branch February 1, 2024 10:34

github-actions bot removed [Status] In Progress [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 1, 2024

github-actions bot added this to the jetpack/13.1 milestone Feb 1, 2024

jeherve mentioned this pull request Feb 1, 2024

Sharing Block: refactor block markup output #35390

Merged

3 tasks

spsiddarthan pushed a commit that referenced this pull request Feb 15, 2024

Sharing buttons style improvements (#35354)

ffac3c4

* add Sharing Buttons color controls * add changelog * fix default colors * fix lint * fix typo * refactor styles * remove unnecessary logic

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sharing buttons style improvements #35354

Sharing buttons style improvements #35354

andrii-lysenko commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024

monsieur-z Jan 31, 2024

andrii-lysenko Jan 31, 2024

monsieur-z Jan 31, 2024

andrii-lysenko Jan 31, 2024

monsieur-z left a comment •

edited

Loading

andrii-lysenko commented Jan 31, 2024

jeherve left a comment

jeherve commented Feb 1, 2024

keoshi commented Feb 1, 2024

Sharing buttons style improvements #35354

Sharing buttons style improvements #35354

Conversation

andrii-lysenko commented Jan 30, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 30, 2024 • edited Loading

github-actions bot commented Jan 30, 2024

monsieur-z Jan 31, 2024

Choose a reason for hiding this comment

andrii-lysenko Jan 31, 2024

Choose a reason for hiding this comment

monsieur-z Jan 31, 2024

Choose a reason for hiding this comment

andrii-lysenko Jan 31, 2024

Choose a reason for hiding this comment

monsieur-z left a comment • edited Loading

Choose a reason for hiding this comment

andrii-lysenko commented Jan 31, 2024

jeherve left a comment

Choose a reason for hiding this comment

jeherve commented Feb 1, 2024

keoshi commented Feb 1, 2024

andrii-lysenko commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024 •

edited

Loading

monsieur-z left a comment •

edited

Loading