exploring masterbar module for new global nav changes

[Addison-Stavlo]

Fixes #

Proposed changes:

• This explores customizing the masterbar module for the purposes of the new top nav.
• We will probably do this in jetpack-mu-wpcom, but exploring this has been helpful to understand what is currently in place and how it works. Our global nav bar is very similar outside of the styles.
• This achieves the slide-out bar for atomic sites, while reverting the admin bar styles. The slide-out bar is still outdated in terms of styles and items compared to our design.
• Current css and js that is enqueued for these is a bit conflated. Ex: to get the style file for the slide-out bar also contains styles that overwrite the way the core dropdown menu buttons look, enabling the slide out bar contains css/js that disables the core user dropdown/button, etc.

My plan to move forward is to create a new class like this in jetpack-mu-wpcom. When it is present, these admin bar customizations will be disabled and reverted to core, while the nav unification level will still be loaded. The jetpack-mu-wpcom class will then customize the specific areas we need, and we will pull in only specific JS and CSS required for our new features.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to '..'

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the try/update-masterbar-for-new-global-nav branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack try/update-masterbar-for-new-global-nav
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• 🔴 Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[Addison-Stavlo]

closing this exploration, we unhooked the functionality in #35642