Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/standalone installation for all products #35399

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Fix/standalone installation for all products #35399

merged 6 commits into from
Feb 2, 2024

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Feb 1, 2024 •
edited
Loading

Proposed changes:

Remove custom is_plugin_installed function for Hybrid_Product class. This function was returning true if Jetpack Core was installed and preventing Standalone plugins from being installed when being purchased from My Jetpack (and potentially other places I am unaware of). Removing it fixes the issue and installs standalone products when the CTA on the product interstitials is clicked

The products fixed are:

  • Jetpack Social
  • Jetpack Backup
  • Jetpack VideoPress
  • Jetpack Search

Boost and Protect use the Product class, not the Hybrid_Product class, so they did not have this issue

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1705686143723779-slack-C06CVN9QVFY

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Use the Jetpack beta plugin to checkout this branch (don't run this locally. The docker setup, by default, has all the standalone plugins installed and I don't know how to easily uninstall and test reinstalling them from the local setup. I debugged this by editing the code on an ephemeral site)
  2. Without any standalone plugins installed, go to /wp-admin/admin.php?page=my-jetpack
  3. Click on "Learn More" on the Jetpack Backup card to get to the interstitial
  4. Click on "Get Jetpack VaultPress Backup". You do not need to purchase the product for this test
    image
  5. Now go to /wp-admin/plugins.php and make sure the VaultPress Backup standalone plugin is installed and active
    image
  6. Repeat steps 2-5 for Social, VideoPress, and Search to make sure they work as well

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/standalone-installation-for-all-products branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/standalone-installation-for-all-products

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Migration plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 1, 2024
@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Feb 1, 2024
jboland88
jboland88 previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@jboland88 jboland88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and tests well.
The class-hybrid-product class has some comments in the class description that read:

"In case Jetpack plugin is active, it will not attempt to install its stand-alone plugin.
But if Jetpack plugin is not active, then it will prompt to install and activate its stand-alone plugin."

We might want to remove that here since we are moving away from that behavior.

jboland88
jboland88 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jboland88 jboland88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after changes 👍

@CodeyGuyDylan CodeyGuyDylan merged commit a9cd697 into trunk Feb 2, 2024
63 of 64 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the fix/standalone-installation-for-all-products branch February 2, 2024 17:08
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 2, 2024
spsiddarthan pushed a commit that referenced this pull request Feb 15, 2024
@CodeyGuyDylan @spsiddarthan
Fix/standalone installation for all products (#35399)
ffd700b 
* Add product specific activation for backup

* changelog

* Remove custom active plugin check from Hybrid_Product

* Update version

* Update lockfiles

* Remove outdated comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jboland88 jboland88 jboland88 approved these changes

Assignees
No one assigned
Labels
[Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeyGuyDylan @jboland88