-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Sync: Add 'jetpack_package_versions' to Sync option whitelist #35409
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Thanks for working on this @fgiannar. I reviewed and approved the WPCOM side of it. I was able to test with the instructions and things worked well for me for my local and a new JN site. The code in this PR looks also fine as far as I can tell but I'd like someone else more familiar with the connection part to take a look and approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested different scenarios, everything works like a charm 👍
Disabling Sync did make it switch to the endpoint, so the fallback also works great.
…#35409) * Jetpack Sync: Add jetpack_package_versions to Sync options
Adds
jetpack_package_versions
option to Sync options' whitelist.Note that since this is a Connection dependant option, there is a fallback in place in order to update the option on WPCOM via a REST request, in case Sync is not present or enabled.
Proposed changes
Sync package:
Automattic\Jetpack\Sync\Defaults
: Addjetpack_package_versions
to Sync options whitelistAutomattic\Jetpack\Sync\Data_Settings
: Addjetpack_package_versions
to the minimum set of Sync options required by Sync itselfConnection package:
Automattic\Jetpack\Connection\Package_Version_Tracker
: Updateupdate_package_versions_option
method to only update thejetpack_package_version
option on WPCOM via a REST request if Sync is not present or enabledOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
D136887-code