-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Register new CPT for Social Posts #35415
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Social plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good start! Just a couple of comments.
|
||
$args = array( | ||
'public' => true, | ||
'label' => 'Social Note', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to add in some of the other labels for the type, and make them translated too. Some examples are in these comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this, Paul, let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that on other types we're using hyphens rather than underscores in the post type slug/name. I don't know if that's a requirement or not!
* Social : Register CPT for Social Notes. * changelog * Social: Added arguments for labels. * Update labels for Social Note: * Hypenate custom post type slug.
Proposed changes:
Jetpack_Social_Note
to register the custom post typedashicons-welcome-write-blog
as the menu icon for now, we can tweak this as well if need be.Other information:
Jetpack product discussion
pdrWKz-156-p2#comment-1932
Does this pull request change what data or activity we track or use?
Testing instructions:
define( 'JETPACK_SOCIAL_NOTES_ENABLED', true );
to yourwp-config.php
. If you're on JN, install the code snippets plugin and copydefine( 'JETPACK_SOCIAL_NOTES_ENABLED', true );
into it.JETPACK_SOCIAL_NOTES_ENABLED
to false and ensure that you no longer see the new CPT in the sidebar.