Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Update Premium Tooltip to use RNA IconTooltip component #35416

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Feb 2, 2024

Fixes #35307

Proposed changes:

  • Update component to usa RNA IconTooltip. This changes the look of the tooltip, but at least is's similar to the rest.

    Before:

    CleanShot 2024-02-02 at 14 36 26

    After:

    CleanShot 2024-02-02 at 14 37 10

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Make sure the tooltip shows up and looks okay.

@dilirity dilirity added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Team Review [Plugin] Boost A feature to speed up the site and improve performance. labels Feb 2, 2024
@dilirity dilirity requested a review from a team February 2, 2024 12:38
@dilirity dilirity self-assigned this Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: March 5, 2024.
  • Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Member

@pyronaur pyronaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dilirity dilirity merged commit ff4226e into trunk Feb 5, 2024
55 of 56 checks passed
@dilirity dilirity deleted the update/boost/critical-css-tooltip branch February 5, 2024 10:47
spsiddarthan pushed a commit that referenced this pull request Feb 15, 2024
* Update Premium Tooltip to use RNA IconTooltip component

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost: Critical CSS tooltip doesn't use RNA component
2 participants