Adding a skeleton of wpcomsh to experiment with running tests. #35792

zinigor · 2024-02-20T19:08:52Z

This is a draft PR, DO NOT MERGE.

Proposed changes:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Go to '..'

github-actions · 2024-02-20T19:15:26Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: May 7, 2024.
Scheduled code freeze: April 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-02-21T17:20:09Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the try/wpcomsh-skeleton-ci branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack try/wpcomsh-skeleton-ci

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

anomiex

Didn't look too closely at the skeleton, just at the rest of the setup.

anomiex · 2024-05-27T13:17:12Z

.github/files/generate-ci-matrix.php

+// Add WooCommerce tests.
+$matrix[] = array(
+	'name'         => 'PHP tests: PHP 7.4 WP latest with WPCOMSH',


Suggested change

// Add WooCommerce tests.

$matrix[] = array(

'name' => 'PHP tests: PHP 7.4 WP latest with WPCOMSH',

// Add wpcomsh tests.

$matrix[] = array(

'name' => 'PHP tests: PHP 8.1 WP latest with WPCOMSH',

anomiex · 2024-05-27T13:21:34Z

.github/files/generate-ci-matrix.php

+$matrix[] = array(
+	'name'         => 'PHP tests: PHP 7.4 WP latest with WPCOMSH',
+	'script'       => 'test-php',
+	'php'          => '8.1',


I wonder if we can avoid hard-coding 8.1 here, to avoid having to remember to update this in the future when Atomic's minimum PHP version changes.

Might it make sense to read wpcomsh's composer.json for .require.php, which I think will probably be ">=8.1", and strip out the ">=" to determine the version to use?

anomiex · 2024-05-27T13:23:22Z

.github/files/setup-wordpress-env.sh

@@ -160,6 +160,16 @@ if [[ "$WITH_WOOCOMMERCE" == true ]]; then
 	echo "::endgroup::"
 fi

+# Install WooCommerce plugin used for some Jetpack integration tests.


Suggested change

# Install WooCommerce plugin used for some Jetpack integration tests.

# Install wpcomsh plugin used for some Jetpack integration tests.

anomiex · 2024-05-27T13:24:27Z

.github/files/setup-wordpress-env.sh

+	echo "::group::Installing wpcomsh into WordPress"
+
+	mkdir "/tmp/wordpress-$WP_BRANCH/src/wp-content/mu-plugins"
+	cp -r "/tmp/wordpress-$WP_BRANCH/src/wp-content/plugins/wpcomsh/src" "/tmp/wordpress-$WP_BRANCH/src/wp-content/mu-plugins/wpcomsh"


This seems wrong. If we need to move it into mu-plugins at all, it should probably be like this

Suggested change

cp -r "/tmp/wordpress-$WP_BRANCH/src/wp-content/plugins/wpcomsh/src" "/tmp/wordpress-$WP_BRANCH/src/wp-content/mu-plugins/wpcomsh"

cp -r "/tmp/wordpress-$WP_BRANCH/src/wp-content/plugins/wpcomsh" "/tmp/wordpress-$WP_BRANCH/src/wp-content/mu-plugins/wpcomsh"

anomiex · 2024-05-27T13:26:41Z

.github/workflows/tests.yml

@@ -46,6 +46,7 @@ jobs:
      NODE_VERSION: ${{ matrix.node }}
      MONOREPO_BASE: ${{ github.workspace }}
      WITH_WOOCOMMERCE: ${{ matrix.with-woocommerce }}
+      WITH_WPCOMSH: ${{ matrix.with-wpcomsh }}


Will you need something below around line 86 as well?

anomiex · 2024-05-27T13:29:00Z

projects/plugins/wpcomsh/src/wpcomsh.php

This file being here instead of in projects/plugins/wpcomsh/wpcomsh.php seems wrong too.

zinigor · 2024-06-13T13:25:57Z

Superceded by #37737

Generated package skeleton.

ea1c9aa

zinigor added [Status] In Progress DO NOT MERGE don't merge it! labels Feb 20, 2024

zinigor added 2 commits February 20, 2024 22:12

Added the first file.

2e74591

Removed a duplicate README file.

f735c3d

zinigor force-pushed the try/wpcomsh-skeleton-ci branch from 47b8c55 to f735c3d Compare February 20, 2024 19:14

github-actions bot added [Tests] Includes Tests Docs [Plugin] Wpcomsh labels Feb 20, 2024

Adding wpcomsh matrix entry.

f0ca110

github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 21, 2024

zinigor added 5 commits February 21, 2024 15:45

Adding the wpcomsh matrix value to the environment.

8b34e43

Fixed the directory.

34adcfb

Using the branch env variable instead.

edc9fea

Adding wpcomsh loading.

5fe70d5

changelog

780f9d5

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 21, 2024

zinigor added 4 commits February 21, 2024 21:21

Properly copy the plugin contents to mu-plugins.

b97785e

Require the correct path.

e7a7bef

Merge branch 'trunk' into try/wpcomsh-skeleton-ci

3d7d3ce

Merge branch 'trunk' into try/wpcomsh-skeleton-ci

016422d

anomiex reviewed May 27, 2024

View reviewed changes

zinigor closed this Jun 13, 2024

zinigor deleted the try/wpcomsh-skeleton-ci branch June 13, 2024 13:26

github-actions bot removed the [Status] In Progress label Jun 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a skeleton of wpcomsh to experiment with running tests. #35792

Adding a skeleton of wpcomsh to experiment with running tests. #35792

zinigor commented Feb 20, 2024

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

anomiex left a comment

anomiex May 27, 2024

anomiex May 27, 2024

anomiex May 27, 2024

anomiex May 27, 2024

anomiex May 27, 2024

anomiex May 27, 2024

zinigor commented Jun 13, 2024

	# Install WooCommerce plugin used for some Jetpack integration tests.
	# Install wpcomsh plugin used for some Jetpack integration tests.

	cp -r "/tmp/wordpress-$WP_BRANCH/src/wp-content/plugins/wpcomsh/src" "/tmp/wordpress-$WP_BRANCH/src/wp-content/mu-plugins/wpcomsh"
	cp -r "/tmp/wordpress-$WP_BRANCH/src/wp-content/plugins/wpcomsh" "/tmp/wordpress-$WP_BRANCH/src/wp-content/mu-plugins/wpcomsh"

Adding a skeleton of wpcomsh to experiment with running tests. #35792

Adding a skeleton of wpcomsh to experiment with running tests. #35792

Conversation

zinigor commented Feb 20, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Feb 20, 2024 • edited Loading

github-actions bot commented Feb 21, 2024 • edited Loading

anomiex left a comment

Choose a reason for hiding this comment

anomiex May 27, 2024

Choose a reason for hiding this comment

anomiex May 27, 2024

Choose a reason for hiding this comment

anomiex May 27, 2024

Choose a reason for hiding this comment

anomiex May 27, 2024

Choose a reason for hiding this comment

anomiex May 27, 2024

Choose a reason for hiding this comment

anomiex May 27, 2024

Choose a reason for hiding this comment

zinigor commented Jun 13, 2024

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading