-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Add e2e tests to Page Cache #36501
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Ready for review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, can we have a test where instead of just checking for the cache header, we look for cache-hit? This will cover more areas of the caching.
@haqadn thanks for the suggestion. I've updated the tests to check the value of the header as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
* Add test for Page Cache meta visibility when module is inactive * Add test for Page Cache header when module is inactive * Add test for Page cache meta visibility when module is active * Add permalink tests for page cache * add changelog * Add cache header test * Update boost CLI to support page cache * Fix test * Update GH actions to include page cache tests * Fix page cache tests * Update file permissions in docker to be writable * Add pnpm script to make files used by page cache writable * Revert permission changes * Fix prepare script * Update script * Update page cache test to check header value as well
Part of #33877
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: