-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configs for simple classic to load odyssey stats #36633
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
projects/packages/stats-admin/tests/php/test-odyssey-config-data.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Some tests are failing but not related to this PR.
See: #36565 and p1711642809295489/1711471112.558629-slack-CDLH4C1UZ for more context.
Sorry I was AFK for the last couple of days, but the changes look good to me! Nice work 👍 |
* Add configs for simple classic to load odyssey stats * changelog * Set the correct value for jetpack * Update unit test * Update unit test to check for is_running_in_jetpack_site --------- Co-authored-by: DustyReagan <[email protected]>
Related https://github.com/Automattic/dotcom-forge/issues/6213
Proposed changes:
jetpack
is_running_in_jetpack_site
is_wpcom_simple
for stats to know whether site is a simple siteOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
See testing instructions in Automattic/wp-calypso#88788