Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configs for simple classic to load odyssey stats #36633

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented Mar 28, 2024

Related https://github.com/Automattic/dotcom-forge/issues/6213

Proposed changes:

  • Set the correct default value for jetpack
  • Set the correct default value for is_running_in_jetpack_site
  • Add a field for is_wpcom_simple for stats to know whether site is a simple site

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

See testing instructions in Automattic/wp-calypso#88788

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/odyssey-stats-config branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/odyssey-stats-config
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@candy02058912 candy02058912 self-assigned this Mar 29, 2024
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Some tests are failing but not related to this PR.
See: #36565 and p1711642809295489/1711471112.558629-slack-CDLH4C1UZ for more context.

@candy02058912 candy02058912 merged commit 1dfa4be into trunk Mar 29, 2024
56 of 57 checks passed
@candy02058912 candy02058912 deleted the update/odyssey-stats-config branch March 29, 2024 07:43
@kangzj
Copy link
Contributor

kangzj commented Apr 1, 2024

Sorry I was AFK for the last couple of days, but the changes look good to me! Nice work 👍

TimBroddin pushed a commit that referenced this pull request Apr 10, 2024
* Add configs for simple classic to load odyssey stats

* changelog

* Set the correct value for jetpack

* Update unit test

* Update unit test to check for is_running_in_jetpack_site

---------

Co-authored-by: DustyReagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants