-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Add e2e tests to concatenate JS/CSS #36668
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. How much longer will the test be if both are combined? If not different by too much, maybe we can combine both? I think it requires workers to run each separately. But, I could be wrong.
projects/plugins/boost/tests/e2e/specs/concatenate-css/concatenate-css.test.js
Outdated
Show resolved
Hide resolved
0a78a31
to
3288ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add data attributes for testing to concatenate JS * Allow concatenate_js to be enabled via Boost's CLI * Add concatenate JS test for meta visibility when inactive * add changelog * Add e2e 'concatenate assets' helper plugin * Add concatenate JS test to make sure concatenation is not happening * Fix incorrect module name * Add test to make sure concat meta is visible when module is active * Add test to verify JS concatenation when module is active * Add Boost's concatenate JS test configuration to e2e test matrix * Add test to verify JS concatenation excludes jquery when enabled * Update concatenate JS tests to rely on custom assets instead * Add e2e tests for concatenate CSS * Add Boost's concatenate CSS test configuration to e2e test matrix * Update selectors in JS/CSS concat tests to allow for greater flexibility * Combine concatenate tests into one
Part of #33877
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: