-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled Gallery Block: remove Plans dependency for VIP Support #36879
Conversation
Follow-up to #13293 Instead of relying on a WordPress.com API request to get the site's plan, and thus to figure out whether the site is on VIP or not, let's rely on the site's constants. That will save us an external request, and will allow to more easily extract the Tiled Gallery block in the future if necessary.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
@mikeyarce I'm not quite sure how I can spin up a VIP site with this patch to test this. Is there anyway you could help with that and test this patch on one of your sandboxes? Thank you! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
This PR has been automatically closed as it has not been updated in some time. If you want to resume work on the PR, feel free to restore the branch and reopen the PR. |
Follow-up to #13293
Proposed changes:
Instead of relying on a WordPress.com API request to get the site's plan, and thus to figure out whether the site is on VIP or not, let's rely on the site's constants. That will save us an external request, and will allow to more easily extract the Tiled Gallery block in the future if necessary.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Note
This would need to be tested on the VIP platform.
i*.wp.com
.