Blogging Prompt: localize wordpress.com link

[monsieur-z]

Fixes #36648

Proposed changes:

This PR localizes the link to wordpress.com in the Blogging Prompt block to be consistent with the site language.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pf5801-Aw-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Prerequisites

• Spin a test site with this branch
• Connect Jetpack
• Create a new post/page
• Add a Blogging Prompt block

Regression testing

• Open the preview
• Check that the link in the block leads to wordpress.com and doesn't contain any lang parameter

Feature testing

• From WPadmin, change the site language in /wp-admin/options-general.php
• Go back to the post/page edition page
• Remove the Blogging Prompt block and add a new one
• Open the preview
• Check that the link in the block leads to wordpress.com and does contain a lang parameter with the site language for value

• Verify the page on wordpress.com isn't broken

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on May 27, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/localize-blogging-prompt-link branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/localize-blogging-prompt-link
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jeherve]

Looks like there are some Phan errors that will need to be addressed before we can merge.

[jeherve]

It's worth noting that @myhro took a different approach in #36730, one that may support more languages, with the caveat I mentioned in my comment there.

Maybe there is something we can do to fix the root problem here?

[monsieur-z]

one that may support more languages

@jeherve, do you mean because it supports both these formats: pt_br, pt-br? I can easily update the code to handle this. While in practice, the endpoint may only be consumed by the Blogging Prompt block, adding the language parameter to the payload returned by the endpoint seems like a more encompassing fix.

[jeherve]

do you mean because it supports both these formats: pt_br, pt-br?

Yes, it's more adapted to the quirks of WordPress.com. I wonder if we should take that opportunity to get a more robust and general solution that we can use everywhere, kinda like what we were discussing in #2707 (comment)

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.