Add/reply to newsletter behaviour setting

[enejb]

Fixes https://github.com/Automattic/jetpack-roadmap/issues/1409

Proposed changes:

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to '..'

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/reply-to-newsletter-setting branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/reply-to-newsletter-setting
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[crisbusquets]

Hi @enejb !

I tested it following the JN link, and this is what I see.

I can't enable the Be sent to the post author's email option. See the video below:

newsletter-replyto.mp4

About the copy

What about:

• Heading: Reply-to settings
• Paragraph: Choose who receives emails when subscribers reply to your newsletter.
• Answer A: Replies are not allowed.
• Answer B: Replies will be sent to the post author's email.

[lezama]

@crisbusquets @enejb updated the wording and fixed the toggle not saving

[simison]

Let's add behind a feature flag at first, so that we can merge early and keep testing/iterating easily.

@pkuliga has good examples of feature flagging on this page with the subscription block toggle PRs.

[lezama]

Server side work code-D146194

[enejb]

@crisbusquets Thanks for the review.

@simison and @lezama I created a PR - #37041
that ads a custom email text field.

I didn't push my changes to this PR mostly since I think this PR is now ready to merge. After Miguel's code-D146194 changes are shipped.

[pkuliga]

@pkuliga has good examples of feature flagging on this page with the subscription block toggle PRs.

We could do it similar to this:
https://github.com/Automattic/jetpack/pull/36073/files

Much simpler approach 😄

[lezama]

We could do it similar to this:
https://github.com/Automattic/jetpack/pull/36073/files

adding it now

[lezama]

Feature flag added:

to turn it on access the newsletter settings like this: https://example.jurassic.tube/wp-admin/admin.php?page=jetpack&enable-newsletter-replyto=true#/newsletter