Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more E2E tests for Jetpack Social #37046

Merged
merged 4 commits into from
May 3, 2024
Merged

Add more E2E tests for Jetpack Social #37046

merged 4 commits into from
May 3, 2024

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Apr 24, 2024 •
edited
Loading

This is a part of #37045 and it adds some E2E tests for Social and we want to continue doing that in future.

Proposed changes:

  • Add E2E tests for Social Admin page and Social Sidebar

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdrWKz-1zy-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Just run the E2E tests

@manzoorwanijk manzoorwanijk added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 24, 2024
@manzoorwanijk manzoorwanijk requested a review from a team April 24, 2024 06:30
@manzoorwanijk manzoorwanijk self-assigned this Apr 24, 2024
@manzoorwanijk manzoorwanijk mentioned this pull request Apr 24, 2024
Merged
3 tasks
@github-actions github-actions bot added [Plugin] Social Issues about the Jetpack Social plugin [Tests] Includes Tests E2E Tests labels Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Social plugin:

  • Next scheduled release: June 4, 2024.
  • Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@manzoorwanijk manzoorwanijk changed the base branch from trunk to fix/timeout-issues-in-e2e April 24, 2024 07:31
@manzoorwanijk manzoorwanijk force-pushed the add/e2e-tests-for-social branch from 140ee44 to c709b6f Compare April 24, 2024 07:35
Base automatically changed from fix/timeout-issues-in-e2e to trunk April 30, 2024 13:57
@manzoorwanijk manzoorwanijk force-pushed the add/e2e-tests-for-social branch from c709b6f to c94241b Compare April 30, 2024 14:04
pablinos
pablinos reviewed May 1, 2024
View reviewed changes
projects/plugins/social/tests/e2e/specs/social-sidebar.test.js
.withActivePlugins( [ 'social' ] )
.withInactivePlugins( [ 'jetpack' ] )
.withLoggedIn( true )
.withWpComLoggedIn( true )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this step is faliing for me. It gets stuck on the confirmation screen after login. It must be something about my environment or other tests would be failing.

Is it still working for you in your dev environment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry meant to attach the screenshot

test-failed-1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still working for you in your dev environment?

Yes.

What error do you see in the console/terminal?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a timeout on this page as it's waiting for the form to be hidden, but that never happens as we need to click on the continue button. Very strange! The GH Action is succeeding too. I've tried cleaning my environment but I get the same problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, many of those workflow utilities are unpredictable and needs more work, which is beyond the scope of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a change in f670105, that looks for the Login button being hidden rather than waiting for the login container to be hidden (which isn't happening sometimes). It works locally for me, but we'll have to see if it works in CI and for everyone else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything changed in that commit you pushed 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! I've committed the wrong file. 49f6911 should have the right changes.

gmjuhasz
gmjuhasz approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run well in headless and headed mode too! Nice one! 👍

@manzoorwanijk manzoorwanijk merged commit a19e183 into trunk May 3, 2024
55 checks passed
@manzoorwanijk manzoorwanijk deleted the add/e2e-tests-for-social branch May 3, 2024 04:46
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablinos pablinos pablinos left review comments

@gmjuhasz gmjuhasz gmjuhasz approved these changes

Assignees

@manzoorwanijk manzoorwanijk

Labels
E2E Tests [Plugin] Social Issues about the Jetpack Social plugin [Tests] Includes Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manzoorwanijk @pablinos @gmjuhasz