-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wpcom marketplate upsell to plugins on WoA sites #37113
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
2be3093
to
25d3dd7
Compare
Since the banner isn't shared across Simple and Atomic, I think having this feature live on wpcomsh would make more sense. |
Maybe we could remove the banner when we search for something (or at least hide it if there are results). It seems a bit out of context to have the banner show up before my search results. The same applies to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is working fine except for 98577cc. I can still see the banner when I have search results. I cleared my cache and all, I'm not getting any JS errors. |
Moved this to wpcomsh: https://github.com/Automattic/wpcomsh/pull/1839 |
Fixes https://github.com/Automattic/dotcom-forge/issues/6001
Proposed changes:
Add a prominent upsell banner from /wp-admin/plugin-install.php to the wpcom plugin marketplace
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: