Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wpcom marketplate upsell to plugins on WoA sites #37113

Closed
wants to merge 17 commits into from

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Apr 29, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/6001

Proposed changes:

Add a prominent upsell banner from /wp-admin/plugin-install.php to the wpcom plugin marketplace

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Create a woa dev site and take it atomic
  2. Use instructions in comment below to apply to the atomic site
  3. Go to /wp-admin/plugin-install.php
  4. See the banner
  5. Click the link in the banner - you should go to the plugin marketplace

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/plugin-upsell branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/plugin-upsell
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

  • Next scheduled release: May 7, 2024.
  • Scheduled code freeze: April 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dsas dsas force-pushed the update/plugin-upsell branch from 2be3093 to 25d3dd7 Compare April 29, 2024 15:05
@dsas dsas self-assigned this Apr 29, 2024
@github-actions github-actions bot added the [Plugin] mu wpcom jetpack-mu-wpcom plugin label Apr 29, 2024
@dsas dsas marked this pull request as ready for review April 29, 2024 15:34
@dsas dsas requested a review from a team April 29, 2024 15:35
@dsas dsas changed the title Update/plugin upsell Add wpcom marketplate upsell to plugins on WoA sites Apr 29, 2024
@rcrdortiz
Copy link
Contributor

Since the banner isn't shared across Simple and Atomic, I think having this feature live on wpcomsh would make more sense.

@rcrdortiz
Copy link
Contributor

When the popular tab is selected the banner is missing some separation with the tab bar.

Screenshot 2024-04-30 at 08 45 23

@rcrdortiz
Copy link
Contributor

rcrdortiz commented Apr 30, 2024

Maybe we could remove the banner when we search for something (or at least hide it if there are results). It seems a bit out of context to have the banner show up before my search results. The same applies to the Favorites tab.

search.mp4

@xavier-lc
Copy link
Contributor

xavier-lc commented Apr 30, 2024

Between 960 and 1200 pixels (page width) the banner looks a bit cluttered, with the logos a bit too close to the text.

image

xavier-lc
xavier-lc previously approved these changes Apr 30, 2024
Copy link
Contributor

@xavier-lc xavier-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a bit bloated between 1120 and 1200 px, but it can be easily fixed. I'm approving 🥇

image

@rcrdortiz
Copy link
Contributor

Everything is working fine except for 98577cc. I can still see the banner when I have search results. I cleared my cache and all, I'm not getting any JS errors.

@dsas
Copy link
Contributor Author

dsas commented Apr 30, 2024

Moved this to wpcomsh: https://github.com/Automattic/wpcomsh/pull/1839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants