Social: Add connection management to the admin page #37120

gmjuhasz · 2024-04-29T15:39:29Z

Fixes https://github.com/Automattic/jetpack-reach/issues/294

Proposed changes:

Updated the backend so the connections return as an array, also populated the response with the needed attributes b6d9c52
Updated the store and frontend handlers to be able to handle the modified structure b47e440
Added the new ConnectionManagement component ece8d5f
Updated the get_profile_link function in base so it handles our new services too 312e2e4

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-reach/issues/294

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

You can switch between the new and old UI with define( 'JETPACK_SOCIAL_USE_ADMIN_UI_V1', true ); in your wp-config file

Go to the social admin page
- You should see the connection list under the main toggle
- All connection should have their name retrieved after the test endpoint finishes
- All connection should have the correct profile picture, or the default service icon if N/A
- Hovering over the name should get a hyperlink to the service profile page. Not working for LinkedIn
- Goto Jetpack Settings > Sharing
- Confirm that the Connections list is displayed
Check that the connection toggles in the editor work as before

Jetpack settings page

Social settings page

github-actions · 2024-04-29T15:40:31Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

Next scheduled release: June 4, 2024.
Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-04-29T15:40:33Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/social-connection-management-component branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/social-connection-management-component

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

This reverts commit b6d9c52.

manzoorwanijk · 2024-05-02T04:39:57Z

@gmjuhasz I resolved the conflicts caused by my PR #37134

projects/plugins/social/src/js/components/header/index.js

projects/plugins/social/src/js/components/social-module-toggle/index.tsx

…d Social

projects/plugins/jetpack/_inc/client/sharing/publicize.jsx

pablinos · 2024-05-05T05:17:24Z

projects/plugins/jetpack/_inc/client/sharing/publicize.jsx

+			const isActive = this.props.getOptionValue( 'publicize' );
+			// Reload the page if Publicize is enabled.
+			if ( isActive && ! window.Initial_State.socialInitialState.is_publicize_enabled ) {
+				window.location.reload();


This seems like a reasonable solution for now. We can work on making API calls for the initial state (if we want to) in the coming weeks.

Yes, Sid created a task to work on the backend parts of it - https://github.com/Automattic/jetpack-reach/issues/310

* Prepare backend aggregation * Update store to use new format * Add component * Update get_profile_link method * changelog * Revert "Prepare backend aggregation" This reverts commit b6d9c52. * Restore 'profile_link' prop * Use feature flag * Fixup versions * Create get_initial_state helper in publicize and use it in Jetpack and Social * Restore admin page hasConnection logic * Fix the connection management for Jetpack and Social admin page * Restore connectionRefreshPath * Fix stylelints * Fix the connection-test-results endpoint * Fix PHP unit tests * Replace deprecated method in tests * Fix mocking for PHP 7 * Fix critical error * No mocking needed now * Set initial state only if publicize is enabled and setup * Reload settings page if publicize is enabled * Use connection package instead of Jetpack class --------- Co-authored-by: Manzoor Wani <[email protected]>

gmjuhasz added 5 commits April 29, 2024 17:31

Prepare backend aggregation

b6d9c52

Update store to use new format

b47e440

Add component

ece8d5f

Update get_profile_link method

312e2e4

changelog

9c255f1

gmjuhasz requested a review from a team April 29, 2024 15:39

gmjuhasz self-assigned this Apr 29, 2024

github-actions bot added [JS Package] Publicize Components [Package] Publicize [Plugin] Social Issues about the Jetpack Social plugin [Status] In Progress RNA labels Apr 29, 2024

manzoorwanijk added 3 commits May 2, 2024 10:07

Revert "Prepare backend aggregation"

54883ca

This reverts commit b6d9c52.

Merge branch 'trunk' into add/social-connection-management-component

0976a2a

Restore 'profile_link' prop

da25a06

manzoorwanijk reviewed May 2, 2024

View reviewed changes

projects/plugins/social/src/js/components/header/index.js Outdated Show resolved Hide resolved

manzoorwanijk reviewed May 2, 2024

View reviewed changes

projects/plugins/social/src/js/components/social-module-toggle/index.tsx Outdated Show resolved Hide resolved

Use feature flag

221fd6a

gmjuhasz marked this pull request as ready for review May 2, 2024 07:58

gmjuhasz requested a review from manzoorwanijk May 2, 2024 07:58

Fixup versions

652b914

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 2, 2024

manzoorwanijk mentioned this pull request May 2, 2024

DRAFT: Social admin page toggles #37105

Closed

3 tasks

manzoorwanijk added 3 commits May 2, 2024 14:40

Create get_initial_state helper in publicize and use it in Jetpack an…

6680fdc

…d Social

Restore admin page hasConnection logic

ce1a305

Fix the connection management for Jetpack and Social admin page

1ca294e

github-actions bot added the [Tests] Includes Tests label May 2, 2024

github-actions bot added the Admin Page React-powered dashboard under the Jetpack menu label May 2, 2024

manzoorwanijk added 2 commits May 2, 2024 15:48

Restore connectionRefreshPath

adad212

Fix stylelints

3a5fa97

pablinos reviewed May 2, 2024

View reviewed changes

projects/plugins/jetpack/_inc/client/sharing/publicize.jsx Show resolved Hide resolved

manzoorwanijk added 10 commits May 2, 2024 18:07

Fix the connection-test-results endpoint

7aa408a

Fix PHP unit tests

7afa438

Merge branch 'trunk' into add/social-connection-management-component

e012385

Replace deprecated method in tests

a100b5e

Fix mocking for PHP 7

2e4d806

Fix critical error

c582ab2

No mocking needed now

dd25185

Set initial state only if publicize is enabled and setup

d01a0bc

Reload settings page if publicize is enabled

66b0aa6

Use connection package instead of Jetpack class

0e773f1

manzoorwanijk approved these changes May 3, 2024

View reviewed changes

gmjuhasz mentioned this pull request May 3, 2024

Social: Add new connection modal #37211

Merged

3 tasks

pablinos reviewed May 5, 2024

View reviewed changes

gmjuhasz merged commit 8debc85 into trunk May 6, 2024
58 checks passed

gmjuhasz deleted the add/social-connection-management-component branch May 6, 2024 07:49

github-actions bot removed the [Status] In Progress label May 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social: Add connection management to the admin page #37120

Social: Add connection management to the admin page #37120

gmjuhasz commented Apr 29, 2024 •

edited by manzoorwanijk

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

manzoorwanijk commented May 2, 2024

pablinos May 5, 2024

manzoorwanijk May 6, 2024

Social: Add connection management to the admin page #37120

Social: Add connection management to the admin page #37120

Conversation

gmjuhasz commented Apr 29, 2024 • edited by manzoorwanijk Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Apr 29, 2024 • edited Loading

github-actions bot commented Apr 29, 2024 • edited Loading

manzoorwanijk commented May 2, 2024

pablinos May 5, 2024

Choose a reason for hiding this comment

manzoorwanijk May 6, 2024

Choose a reason for hiding this comment

gmjuhasz commented Apr 29, 2024 •

edited by manzoorwanijk

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading

github-actions bot commented Apr 29, 2024 •

edited

Loading