Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nav upsell RTL padding #37125

Merged
merged 10 commits into from
May 1, 2024
Merged

Fix/nav upsell RTL padding #37125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a13dd31
Fix navigation upsell RTL padding
DustyReagan Apr 29, 2024
8c5d6dc
changelog
DustyReagan Apr 29, 2024
64ec298
Fix RTL notice close button
DustyReagan Apr 29, 2024
918c440
Try fix folded RTL
DustyReagan Apr 29, 2024
cb18d85
Try fix folded RTL
DustyReagan Apr 29, 2024
f889a72
Try fix folded RTL
DustyReagan Apr 29, 2024
a8c17f4
Try fix folded RTL
DustyReagan Apr 29, 2024
81c4ac1
Try fix folded RTL
DustyReagan Apr 29, 2024
cb607de
Update projects/packages/jetpack-mu-wpcom/src/features/wpcom-site-men…
DustyReagan Apr 30, 2024
e68b259
Update changelog
DustyReagan Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/jetpack-mu-wpcom/changelog/fix-nav-upsell-rtl-padding
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Fix navigation upsell and notification RTL spacing.
2 changes: 1 addition & 1 deletion projects/packages/jetpack-mu-wpcom/src/features/wpcom-site-menu/wpcom-site-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ function wpcom_add_hosting_menu_intro_notice() {

.wpcom-site-menu-intro-notice a.close-button {
height: 16px;
margin-left: auto;
margin-inline-start: auto;
}
</style>
<div class="wpcom-site-menu-intro-notice notice notice-info" role="alert">
Expand Down
8 changes: 6 additions & 2 deletions projects/packages/jetpack-mu-wpcom/src/features/wpcom-site-menu/wpcom-site-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@
}

.wp-menu-name {
padding-top: 0;
padding-left: 8px;
padding: 0 8px 8px 8px;
}

.upsell_banner {
Expand Down Expand Up @@ -148,6 +147,11 @@
@include folded;
}

.rtl.folded #adminmenu li.toplevel_page_site-notices .wp-menu-name {
right: auto;
padding-right: 4px;
}

@media only screen and (max-width: 960px) and (min-width: 783px) {
.auto-fold {
@include folded;
Expand Down
Loading