Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Restore: Add is_deleted attribute to sites api response to flag deleted sites #37142

Merged
merged 2 commits into from
May 1, 2024

Conversation

vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Apr 30, 2024

Relates to Automattic/wp-calypso#89825

Proposed changes:

  • add is_deleted attribute to site api response

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply changes to your sandbox
  • Apply D147075-code
  • Go to /settings/delete-site/ and delete a site
  • Use developer console to fetch the deleted site WP.COM API GET v1.2/me/sites?site_visibility=deleted
  • Verify is_deleted field is present and is true
    image

@vykes-mac vykes-mac self-assigned this Apr 30, 2024
@vykes-mac vykes-mac added Build Maintenance Build Group maintenance tasks [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 30, 2024
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/site-is-deleted-field branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/site-is-deleted-field
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Apr 30, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@vykes-mac vykes-mac changed the title Site Restore: Site Restore: Add is_deleted attribute to sites api response to flag deleted sites Apr 30, 2024
@vykes-mac vykes-mac requested a review from mpkelly May 1, 2024 01:48
@mpkelly
Copy link
Contributor

mpkelly commented May 1, 2024

Tested and working. 🚀

@mpkelly mpkelly force-pushed the add/site-is-deleted-field branch from cfd449a to 97a85f9 Compare May 1, 2024 09:40
@mpkelly mpkelly force-pushed the add/site-is-deleted-field branch from 97a85f9 to d16d988 Compare May 1, 2024 13:02
@mpkelly
Copy link
Contributor

mpkelly commented May 1, 2024

Synced some changes to WPCOM here D147242-code.

@vykes-mac vykes-mac merged commit 38a5ee8 into trunk May 1, 2024
56 checks passed
@vykes-mac vykes-mac deleted the add/site-is-deleted-field branch May 1, 2024 22:28
@github-actions github-actions bot added this to the jetpack/13.4 milestone May 1, 2024
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label May 1, 2024
@mpkelly
Copy link
Contributor

mpkelly commented May 2, 2024

I deployed D147354-code to get this on Simple now in advance of the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Maintenance Build Group maintenance tasks [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants