ci: Avoid suggesting unnecessary baseline updates #37158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
When checking for baselines that need updating due to fixed issues, we ignore the "issue statistics" comment at the top of the file so as to not make people have to update the baselines unnecessarily.
However, if one project has a real update needed while a different one has only comments, we're still instructing the author to update both of them even though only the former is needed.
Let's not do that.
Other information:
Jetpack product discussion
Inspired by p1714573052936929-slack-CDLH4C1UZ
Does this pull request change what data or activity we track or use?
No
Testing instructions:
jetpack phan --update-baseline
for the first, not the second.