Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Add featured image video to Jetpack AI product page #37192

Merged

Conversation

lhkowalski
Copy link
Contributor

@lhkowalski lhkowalski commented May 2, 2024

Fixes #37191.

Proposed changes:

  • Add section for the Featured Image generation feature
  • Rename some var to make it easy do changes on the page in the future
  • Change the forms link and the content feedback link to use dynamic links too
Before After
Screenshot 2024-05-02 at 16 06 22 Screenshot 2024-05-02 at 15 39 43

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Get a new site running and connect it
  • Visit the My Jetpack page and look for the "AI" product card
  • Click the Learn more button
Screenshot 2024-05-02 at 16 03 13
  • On the following page, choose to keep using Jetpack AI for free (or upgrade, it does not affect the end result)
Screenshot 2024-05-02 at 16 03 58
  • You will land on the Jetpack AI product page
  • Confirm the page now shows 4 videos instead of 3:
Screenshot 2024-05-02 at 15 39 43
  • Confirm the second video of the page is related to the featured image generation
  • Confirm the title, description and link have the correct words (check p1HpG7-sig-p2 for reference)
  • Confirm the video plays correctly and is the correct video
  • Confirm the thumbnail for the video is correct
  • Confirm the link on the video leads you to the https://wordpress.com/support/featured-images/ support page

  • Since we are changing the forms link and the content feedback link to use dynamic links too:
  • Confirm the Forms link (third video) leads to the correct page
  • Confirm the Content Feedback link (fourth video) leads to the page it was leading before (not ideal, but probably the only one we could put at the time)

@lhkowalski lhkowalski self-assigned this May 2, 2024
@lhkowalski lhkowalski requested a review from a team May 2, 2024 18:48
@lhkowalski lhkowalski added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] My Jetpack labels May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-add-featured-image-video-to-product-page branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-add-featured-image-video-to-product-page
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented May 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for May 7, 2024 (scheduled code freeze on May 6, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@lhkowalski lhkowalski marked this pull request as ready for review May 2, 2024 18:52
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhkowalski lhkowalski merged commit 0a8a39f into trunk May 2, 2024
71 checks passed
@lhkowalski lhkowalski deleted the update/jetpack-ai-add-featured-image-video-to-product-page branch May 2, 2024 20:51
@github-actions github-actions bot added this to the jetpack/13.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Featured Image: add video entry on the product page, on My Jetpack
2 participants