Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Create a social service connect button #37196
Social: Create a social service connect button #37196
Changes from 2 commits
b8d5b9b
6807004
f1befb6
367d4d3
0956e84
acafc61
0626867
dbdd119
b68888d
32d58c2
fc07f14
9bdf474
6bb8c21
76fbc84
94cf5a0
d9459d3
f6bb5b8
a01d0e2
1ee81d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check failure on line 99 in projects/js-packages/publicize-components/src/components/add-connection-modal/index.tsx
GitHub Actions / ESLint (non-excluded files only)
Check failure on line 99 in projects/js-packages/publicize-components/src/components/add-connection-modal/index.tsx
GitHub Actions / ESLint (non-excluded files only)
Check failure on line 219 in projects/packages/publicize/src/jetpack-social-settings/class-settings.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check failure on line 224 in projects/packages/publicize/src/jetpack-social-settings/class-settings.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check failure on line 227 in projects/packages/publicize/src/jetpack-social-settings/class-settings.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check warning on line 268 in projects/plugins/social/src/class-jetpack-social.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check warning on line 268 in projects/plugins/social/src/class-jetpack-social.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check failure on line 272 in projects/plugins/social/src/class-jetpack-social.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API call should probably be cached, so we're not making another API request on each load of the admin page, especially as this data will not change very often
Check failure on line 275 in projects/plugins/social/src/class-jetpack-social.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check failure on line 280 in projects/plugins/social/src/class-jetpack-social.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)
Check failure on line 283 in projects/plugins/social/src/class-jetpack-social.php
GitHub Actions / PHP Code Sniffer (non-excluded files only)