Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics: automatically label changes to package #37205

Merged
merged 1 commit into from
May 3, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 3, 2024

See #37137

Proposed changes:

The Google Analytics feature now also lives in a package. Let's handle that in our action.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Note

This can only be tested in a fork.

  • In your fork, merge this branch to trunk.
  • Open a new PR in your fork, for a new branch to trunk, making a change to one of the files in projects/packages/google-analytics/.
    • The "[Feature] Google Analytics" label should be automatically added to the PR.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal [Feature] Google Analytics [Status] Needs Team Review labels May 3, 2024
@jeherve jeherve requested review from sergeymitr and a team May 3, 2024 09:44
@jeherve jeherve self-assigned this May 3, 2024
@jeherve jeherve enabled auto-merge (squash) May 3, 2024 09:44
@github-actions github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management labels May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@jeherve jeherve merged commit a7be64f into trunk May 3, 2024
55 checks passed
@jeherve jeherve deleted the update/repo-gardening-google-analytics branch May 3, 2024 17:45
@github-actions github-actions bot removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Feature] Google Analytics [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants