-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Form: Replacing the tinymce JS file path with non minified, preventing editor errors #37270
Conversation
…tor errors on WoA sites
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me 👍
…reventing editor errors (#37270) * Replacing the minified JS file path with non minified, to prevent editor errors on WoA sites * changelog * Update package versions
…reventing editor errors (#37270) * Replacing the minified JS file path with non minified, to prevent editor errors on WoA sites * changelog * Update package versions
Proposed changes:
Other information:
Jetpack product discussion
Multiple reports were also made here (only relevant to recent reports): #10919
p1715102635937589-slack-C02FMH4G8
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
To replicate the issue, on a WoA site running the most recent Jetpack version, make sure the contact form is enabled at
/wp-admin/admin.php?page=jetpack_modules
Also, make sure the Classic Editor plugin is installed and active
Then attempt to create a new post - you will see an error beginning with 'Failed to load plugin url:....' , referring to
tinymce-plugin-form-button.min.js
.To test the fix, on a WoA site with the Jetpack Beta tester plugin installed (or an WoA dev site using rsync), apply this patch.
Follow the same steps as above.
Attempt to create a new post - you should not see any errors.
The fix should also work on a Jetpack local development site (though the issue itself isn't replicable there)