Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form: Replacing the tinymce JS file path with non minified, preventing editor errors #37270

Merged
merged 3 commits into from
May 7, 2024

Conversation

coder-karen
Copy link
Contributor

@coder-karen coder-karen commented May 7, 2024

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Multiple reports were also made here (only relevant to recent reports): #10919

p1715102635937589-slack-C02FMH4G8

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • To replicate the issue, on a WoA site running the most recent Jetpack version, make sure the contact form is enabled at /wp-admin/admin.php?page=jetpack_modules

  • Also, make sure the Classic Editor plugin is installed and active

  • Then attempt to create a new post - you will see an error beginning with 'Failed to load plugin url:....' , referring to tinymce-plugin-form-button.min.js.

  • To test the fix, on a WoA site with the Jetpack Beta tester plugin installed (or an WoA dev site using rsync), apply this patch.

  • Follow the same steps as above.

  • Attempt to create a new post - you should not see any errors.

The fix should also work on a Jetpack local development site (though the issue itself isn't replicable there)

Copy link
Contributor

github-actions bot commented May 7, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/contact-form-tiny-mce-editor-min-error branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/contact-form-tiny-mce-editor-min-error
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented May 7, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@coder-karen coder-karen added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels May 7, 2024
@coder-karen coder-karen requested review from a team and ice9js May 7, 2024 18:29
Copy link
Member

@ice9js ice9js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me 👍

@ice9js ice9js added [Status] Needs Cherry-Pick and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 7, 2024
@ice9js ice9js merged commit 4a59c08 into trunk May 7, 2024
56 of 57 checks passed
@ice9js ice9js deleted the fix/contact-form-tiny-mce-editor-min-error branch May 7, 2024 18:47
ice9js pushed a commit that referenced this pull request May 7, 2024
…reventing editor errors (#37270)

* Replacing the minified JS file path with non minified, to prevent editor errors on WoA sites

* changelog

* Update package versions
pkuliga pushed a commit that referenced this pull request May 9, 2024
…reventing editor errors (#37270)

* Replacing the minified JS file path with non minified, to prevent editor errors on WoA sites

* changelog

* Update package versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants