Add Admin Interface Style options to Settings > General

[lupus2k]

Related https://github.com/Automattic/dotcom-forge/issues/6942

Proposed changes:

Add Admin Interface Style options to wp-admin/options-general.php

Show it to all Atomic sites and Simple sites with wpcom_classic_early_release enabled.
It should not show on Atomic sites without wpcom_classic_early_release or disabled.

To-do

• Make it save the option

Jetpack product discussion

https://github.com/Automattic/dotcom-forge/issues/6942

Does this pull request change what data or activity we track or use?

no

Testing instructions:

• Go to /wp-admin/options-general.php
• You should see Admin Interface Style on all Atomic Sites or Simple sites with wpcom_classic_early_release enabled
• You should not see it in a Simple Sites without wpcom_classic_early_release

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/admin-interface-style-to-settings branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/admin-interface-style-to-settings
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Mu Wpcom plugin:

• Next scheduled release: June 4, 2024.
• Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[arthur791004]

Make it save the option

Handled by dffd587

[miksansegundo]

@arthur791004 is this still in progress? It seems completed because the option is now saved.

Screen.Recording.2567-05-08.at.17.31.00.mov

[arthur791004]

is this still in progress?

It's ready for review!

[miksansegundo]

Tests / Static analysis is failing twice:

It seems that we have to add stubs for Dotcom, following the instructions in

jetpack/.phan/stubs/wpcom-stubs.php

Line 3 in 5ebbada

* Do not edit this directly! Update the definition file in the wpcom repo at

[DustyReagan]

Works great! 🎉