Contact Form: Allow users to add multiple options to a dropdown field

[monsieur-z]

Fixes #37565

Proposed changes:

A recent Gutenberg update (from 18.3 to 18.4.0 RC1) broke the Contat Form dropdown field: users could not add more than one option. The issue was caused by the onSplit prop being removed from the RichText component.

This PR fixes it by adding a listener to the Enter key and applying similar logic to that implemented in the onSplit callback.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Note: I personally tested the fix in Chrome, Safari, and Firefox.

To reproduce the issue

• Spin up a Jetpack test site (the issue happens with self-hosted, simple, and atomic sites)
• If you're using a self-hosted site, you may need to install the Gutenberg plugin manually to ensure the version is 18.4 or above
• Create a new post
• Add a Contact Form block
• Add a dropdown field
• Notice you cannot add more than one option: hitting the Enter keys does nothing

To test the fix

• Checkout this branch
• Repeat the steps above
• Verify that you can add several options
• Check that the dropdown renders as expected in the frontend
• Optionally, test the fix with other types of site

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/dropddown-field-options branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/dropddown-field-options
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[coder-karen]

Tested on self-hosted (also self-hosted without Gutenberg active), Atomic and Simple, and works well 👍