Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor plugins: do not load post editor plugins in site editor #37819

Closed
wants to merge 1 commit into from

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jun 12, 2024

Proposed changes:

This is related to the changes mentioned in #37713.

Starting in WP 6.6, we need to explicitely ensure that editor plugins that can only be used in the post editor are only loaded there.

In this PR, we'll do this by checking for an existing post type.

  • Internal reference: p1718201200111879-slack-C03EL5U0PS6

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start by installing the WordPress Beta Tester plugin, and then switching your site to use the bleeding edge version of WP.
  • Go to My Jetpack and connect your site to your WordPress.com account.
  • Go to Appearance > Editor (if you use a classic theme that menu item will not be available ; switch to the Twenty Twenty Four theme to see the menu item)
  • Ensure that the Jetpack plugin sidebar is not displayed.

This is related to the changes mentioned in #37713.

Starting in WP 6.6, we need to explicitely ensure that editor plugins that can only be used in the post editor are only loaded there.

- Epic: #36721
- Internal reference: p1718201200111879-slack-C03EL5U0PS6
@jeherve jeherve added [Status] In Progress [Type] Janitorial [Pri] Normal [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg labels Jun 12, 2024
@jeherve jeherve self-assigned this Jun 12, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/site-editor-plugins branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/site-editor-plugins
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Extension] AI Assistant Plugin [Extension] Post Publish QR Post Panel [Extension] SEO [Extension] Social Previews Social Preview block editor plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jun 12, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve
Copy link
Member Author

jeherve commented Jun 13, 2024

Noting that this won't work. Putting this on hold for now, exploring other options.

@jeherve
Copy link
Member Author

jeherve commented Jun 14, 2024

Noting that this may no longer be necessary, thanks to changes that may potentially land in Gutenberg soon:
WordPress/gutenberg#62531

@jeherve jeherve closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [Extension] Post Publish QR Post Panel [Extension] SEO [Extension] Social Previews Social Preview block editor plugin [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Blocked / Hold [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant