Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a4a client: updates to readme #37820

Merged
merged 1 commit into from
Jun 12, 2024
Merged

a4a client: updates to readme #37820

merged 1 commit into from
Jun 12, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jun 12, 2024

Proposed changes:

Janitorial changes to ensure the plugin uses the right stable tag, is set to be automatically released when we release a new GitHub version, and a few minor tweaks to the readme as well (add some humans to the contributor list, remove useless PR numbers).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • p1718198708233069-slack-C01U2KGS2PQ

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Not much to test this time around. Look that anything makes sense I suppose.

Janitorial changes to ensure the plugin uses the right stable tag, is set to be automatically released when we release a new GitHub version, and a few minor tweaks to the readme as well (add some humans to the contributor list, remove useless PR numbers).
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jun 12, 2024
@jeherve jeherve self-assigned this Jun 12, 2024
@jeherve jeherve enabled auto-merge (squash) June 12, 2024 15:38
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Automattic For agencies client plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve jeherve merged commit 33eef67 into trunk Jun 12, 2024
55 checks passed
@jeherve jeherve deleted the update/a4a-readme-2 branch June 12, 2024 15:46
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants