Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Logos: Rewrite svg-optimize script in JS #37831

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

tbradsha
Copy link
Contributor

As the title says, this rewrites said script in JS.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Make sure ./tools/build continues to create optimized SVGs in ./build/svg-clean as before.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-logos/do_svg_optimize_with_js branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-logos/do_svg_optimize_with_js
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-logos/do_svg_optimize_with_js
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the RNA label Jun 12, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 12, 2024
anomiex
anomiex previously approved these changes Jun 13, 2024
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The built artifacts are almost all the same, the only difference is addition of newlines at EOF in build/svg-clean/ which makes no difference to anything else.

Two suggestions inline, but feel free to ignore them if you want.

projects/js-packages/social-logos/tools/svg-optimize.js Outdated Show resolved Hide resolved
projects/js-packages/social-logos/tools/svg-optimize.js Outdated Show resolved Hide resolved
anomiex
anomiex previously approved these changes Jun 13, 2024
@tbradsha tbradsha enabled auto-merge (squash) June 13, 2024 17:21
anomiex
anomiex previously approved these changes Jun 13, 2024
@tbradsha tbradsha force-pushed the update/social-logos/do_svg_optimize_with_js branch from f95cf30 to 293f598 Compare June 13, 2024 17:40
@tbradsha tbradsha merged commit 89daed8 into trunk Jun 13, 2024
71 of 72 checks passed
@tbradsha tbradsha deleted the update/social-logos/do_svg_optimize_with_js branch June 13, 2024 18:02
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants