Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Proofread: Get and apply suggestions #38344

Merged
merged 19 commits into from
Jul 17, 2024
Merged

Conversation

renatoagds
Copy link
Contributor

@renatoagds renatoagds commented Jul 15, 2024

Get and apply suggestions.

ONLY working with Complex Words.
NEEDS: D155332-code

Proposed changes:

  • Add UI for suggestion.
  • Add handling suggestion.
  • Saving suggestion on store.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

  • Make sure to sandbox your WPCOM.
  • Go to your editor.
  • Add some post that has Complex Words.
  • Ask for Suggest.
  • It should suggest.
  • Accept it.
  • It should replace the word.

@renatoagds renatoagds changed the base branch from trunk to update/ai-proofread-popover-ux July 15, 2024 22:58
@github-actions github-actions bot added [Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress RNA labels Jul 15, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/proofread-get-suggestions branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/proofread-get-suggestions
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/proofread-get-suggestions
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@renatoagds renatoagds force-pushed the add/proofread-get-suggestions branch from efd629a to 3fa36d8 Compare July 16, 2024 17:32
@renatoagds renatoagds self-assigned this Jul 16, 2024
@renatoagds renatoagds force-pushed the add/proofread-get-suggestions branch 2 times, most recently from 51b7537 to be625c5 Compare July 16, 2024 20:01
Base automatically changed from update/ai-proofread-popover-ux to trunk July 16, 2024 20:10
@renatoagds renatoagds force-pushed the add/proofread-get-suggestions branch from be625c5 to 0f8ab15 Compare July 16, 2024 20:14
@renatoagds renatoagds requested a review from a team July 16, 2024 20:18
@renatoagds renatoagds marked this pull request as ready for review July 16, 2024 20:18
Comment on lines +59 to +62
const config = features?.find?.( ftr => ftr.config.name === anchorFeature )?.config ?? {
name: '',
title: '',
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used

dhasilva
dhasilva previously approved these changes Jul 16, 2024
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single updates work. There are some issues with suggestion invalidation and multiple instances of the same word, but let's iterate on follow-ups.

@renatoagds renatoagds force-pushed the add/proofread-get-suggestions branch from 3f87507 to 4811d5a Compare July 17, 2024 19:36
@renatoagds renatoagds enabled auto-merge (squash) July 17, 2024 20:16
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renatoagds renatoagds merged commit e9e6046 into trunk Jul 17, 2024
72 checks passed
@renatoagds renatoagds deleted the add/proofread-get-suggestions branch July 17, 2024 20:18
@github-actions github-actions bot added this to the jetpack/13.7 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants