-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide wpcom features when site is agency-managed or user is local #38364
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
2756596
to
6eba014
Compare
6eba014
to
99db7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through each scenario. Everything checks out. Nicely done!
Fixes https://github.com/Automattic/dotcom-forge/issues/8197
Proposed changes:
This PR disables the following wpcom-only features if the site is fully agency-managed, or if the user is a local user (not connected to WordPress.com).
It works by consolidating the scattered
is_agency_managed()
checks as follows:is_wpcom_user()
as discussed here https://github.com/Automattic/dotcom-forge/issues/8197#issuecomment-2221890883.load_wpcom_user_features()
, instead of gating individual hooks.Note
It looks like Plugin Marketplace banner is still shown to non-wpcom user. I asked for clarification here: https://github.com/Automattic/jetpack/pull/38241/files#r1680796660 cc: @Addison-Stavlo
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Test the following scenarios:
is_fully_managed_agency_site
option is1
on that site