My Jetpack: replace Creator card with Newsletter #38418

IanRamosC · 2024-07-19T01:18:50Z

More context: p1HpG7-sYs-p2

Proposed changes:

This PR adds a new card for Newsletter and replaces Creator with it. The CTA in the card links to the Newsletter settings page

Not connected:

User connected with settings off:

User connected with settings on:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-sYs-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Spin up a JN site with Jetpack Beta pointing to this branch
Go to My Jetpack and confirm that you see "Newsletter" instead of "Creator"
The button in the card will always link to the settings page on the Newsletter menu
- If the user is not connected to Jetpack, that will redirect to the User connection screen
- If the user is connected, you'll see the Newsletter section on the Settings page.
After turning the settings on, if you go back to My Jetpack, you'll see the card marked as Active

github-actions · 2024-07-19T01:19:35Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/newsletter-card branch.
To test on Simple, run the following command on your sandbox:
```
bin/jetpack-downloader test jetpack add/newsletter-card
```

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-07-19T01:20:06Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

CodeyGuyDylan

Tested mostly well, I left a few comments that i think are important enough to address or talk about before merging 😄

CodeyGuyDylan · 2024-07-22T19:18:16Z

projects/packages/my-jetpack/_inc/components/product-cards-section/newsletter-card.jsx

+			label: __( 'View', 'jetpack-my-jetpack' ),
+			onClick: () => {},
+		},
+		[ PRODUCT_STATUSES.MODULE_DISABLED ]: {


With this PR we've gone towards allowing the user to "Activate" the module/plugin from My Jetpack if at all possible. Could we possibly continue that trend here? Would the activate function work here or is there a reason we need to have the user do it from the settings page?

CodeyGuyDylan · 2024-07-22T19:18:51Z

projects/packages/my-jetpack/_inc/components/product-cards-section/index.tsx

 type DisplayItemType = Record<
 	// We don't have a card for Security or Extras, and scan is displayed as protect.
-	Exclude< JetpackModule, 'extras' | 'scan' | 'security' >,
+	Exclude< JetpackModule, ExcludedModules >,


Nice improvements with the excludes, thanks!

CodeyGuyDylan · 2024-07-22T19:19:20Z

projects/packages/my-jetpack/_inc/components/product-cards-section/newsletter-card.jsx

@@ -0,0 +1,36 @@
+import { __ } from '@wordpress/i18n';


Since this is a brand new file, what do you think about converting it to TypeScript since we are heading that direction in My Jetpack?

CodeyGuyDylan · 2024-07-22T19:23:22Z

projects/packages/my-jetpack/src/products/class-newsletter.php

+		if ( Products::STATUS_MODULE_DISABLED === $status && ! Initializer::is_registered() ) {
+			// If the site has never been connected before, show the "Learn more" CTA.
+			// It should point to the settings page where the user can manage Newsletter
+			$status = Products::STATUS_NEEDS_PURCHASE_OR_FREE;


This status has been replaced with STATUS_NEEDS_ACTIVATION in the PR I linked to in a previous comment FYI, you might want to rebase and update that so there are no issues with an undefined constant 😄

crisbusquets · 2024-08-07T16:27:52Z

Just a note that we also need to update the emails we send when the user upgrades:

Should I create a new issue for this, @IanRamosC ?

pkuliga · 2024-09-04T20:56:07Z

Hi @IanRamosC, I just came across this and I'm wondering, what is the status of this work?

Are we giving up on it or still want to move it forward?

crisbusquets · 2024-09-13T14:59:15Z

Paused until Nov.
Context: p1726211355297409-slack-C02LK1W8T4Z.

github-actions · 2024-12-13T00:50:17Z

This PR has been marked as stale. This happened because:

It has been inactive for the past 3 months.
It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

IanRamosC added 2 commits July 18, 2024 22:10

Add product class for Newsletter

b83a31b

changelog

f8e8dc2

github-actions bot added [Package] My Jetpack [Status] In Progress labels Jul 19, 2024

IanRamosC added 2 commits July 18, 2024 22:28

Fix Phan issues

c5e75cf

My Jetpack: replace Creator card with Newsletter

0896c03

IanRamosC force-pushed the add/newsletter-card branch from f31d695 to 0896c03 Compare July 19, 2024 02:31

IanRamosC added 7 commits July 19, 2024 00:09

My Jetpack: fix product excludes

2f1588a

Update get_products_by_ownership to always return array values

d40475f

Add override for newsletter actions

15205a0

Remove upgradeInInterstitial prop in the card

3036eb3

Add override for missing status

a5e1f25

Link Newsletter card specific settings page

279b45a

Add override for other common Newsletter statuses

f702051

IanRamosC self-assigned this Jul 21, 2024

IanRamosC added [Status] Needs Team Review and removed [Status] In Progress labels Jul 21, 2024

github-actions bot added the [Status] In Progress label Jul 21, 2024

IanRamosC changed the title ~~Add/newsletter card~~ My Jetpack: replace Creator card with Newsletter Jul 21, 2024

IanRamosC removed the [Status] In Progress label Jul 21, 2024

IanRamosC marked this pull request as ready for review July 21, 2024 14:55

github-actions bot added the [Status] In Progress label Jul 21, 2024

crisbusquets self-assigned this Jul 22, 2024

CodeyGuyDylan requested changes Jul 22, 2024

View reviewed changes

github-actions bot added the [Status] Stale label Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

My Jetpack: replace Creator card with Newsletter #38418

My Jetpack: replace Creator card with Newsletter #38418

IanRamosC commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024

CodeyGuyDylan left a comment

CodeyGuyDylan Jul 22, 2024

CodeyGuyDylan Jul 22, 2024

CodeyGuyDylan Jul 22, 2024

CodeyGuyDylan Jul 22, 2024

crisbusquets commented Aug 7, 2024

pkuliga commented Sep 4, 2024

crisbusquets commented Sep 13, 2024

github-actions bot commented Dec 13, 2024

My Jetpack: replace Creator card with Newsletter #38418

Are you sure you want to change the base?

My Jetpack: replace Creator card with Newsletter #38418

Conversation

IanRamosC commented Jul 19, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jul 19, 2024 • edited Loading

github-actions bot commented Jul 19, 2024

CodeyGuyDylan left a comment

Choose a reason for hiding this comment

CodeyGuyDylan Jul 22, 2024

Choose a reason for hiding this comment

CodeyGuyDylan Jul 22, 2024

Choose a reason for hiding this comment

CodeyGuyDylan Jul 22, 2024

Choose a reason for hiding this comment

CodeyGuyDylan Jul 22, 2024

Choose a reason for hiding this comment

crisbusquets commented Aug 7, 2024

pkuliga commented Sep 4, 2024

crisbusquets commented Sep 13, 2024

github-actions bot commented Dec 13, 2024

IanRamosC commented Jul 19, 2024 •

edited

Loading

github-actions bot commented Jul 19, 2024 •

edited

Loading