-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MU WPCOM: Port the newspack blocks from the ETK #38454
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
097a7f4
to
474be25
Compare
@arthur791004: can we fix the conflict first? I'll then test it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all scenarios. Nice job!
I also tested with and without ETK plugin active.
Blog Posts block
Editor | Frontend |
---|---|
Post Carousel block
Editor | Frontend |
---|---|
Since this is a big change... I advise to only merge this after we have deployed #38526 to Atomic... What do you think?
Sounds good! |
@arthur791004 let's rebase this PR again 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke-tested again on Simple and Atomic sites, and it still works fine.
But I'm still not confident merging this before deploying wpcomsh 5.0.2. 😭
Let's merge this on next week 😉 |
projects/packages/jetpack-mu-wpcom/src/features/newspack-blocks/index.php
Outdated
Show resolved
Hide resolved
This reverts commit 71819c1.
* Revert "MU WPCOM: Port the newspack blocks from the ETK (#38454)" This reverts commit 71819c1. * Changelog. --------- Co-authored-by: Igor Zinovyev <[email protected]>
Related to https://github.com/Automattic/dotcom-forge/issues/8208, https://github.com/Automattic/dotcom-forge/issues/8036
Proposed changes:
redux
,redux-saga
, andswiper
to dependencies as they're required by the@automattic/newspack-blocks
strict-peer-dependencies = true
. So, there are some errors if we install the@automattic/newspack-blocks
package directly due to the mismatched peer dependencies versions.jscodeshift
to fixOptimization seems to have broken the following translation strings
issue due to the bad minification as followsBlog Posts
block from the ETKPost Carousel
block from the ETKOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Apply changes to wpcom or atomic sites
Go to the Editor
Insert the
Blog Posts
andPost Carousel
Make sure they display correctly in the Editor
Save & Refresh the page
Make sure they still display correctly
Go to your frontend page
Make sure they work well your the frontend page