Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpcomsh: Update wc-calypso-bridge to 2.5.5 #38469

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

JulianBustamante
Copy link
Contributor

@JulianBustamante JulianBustamante commented Jul 23, 2024

Proposed changes:

This PR bumps the version of wc-calypso-bridge to 2.5.5, which includes the following change:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

The changes related to the wc-calypso-bridge were already tested in the related PR Automattic/wc-calypso-bridge#1492. In that PR, there are some testing instructions

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@JulianBustamante JulianBustamante self-assigned this Jul 23, 2024
@JulianBustamante JulianBustamante force-pushed the update-wc-calypso-bridge-2.5.5 branch from 0d38131 to 71a1ef7 Compare July 23, 2024 23:13
@JulianBustamante JulianBustamante changed the title Update wc-calypso-bridge to 2.5.5 wpcomsh: Update wc-calypso-bridge to 2.5.5 Jul 23, 2024
@JulianBustamante JulianBustamante added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jul 24, 2024
@JulianBustamante JulianBustamante marked this pull request as ready for review July 24, 2024 03:29
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Haven't tested.

@JulianBustamante JulianBustamante merged commit 36b2d52 into trunk Jul 24, 2024
53 checks passed
@JulianBustamante JulianBustamante deleted the update-wc-calypso-bridge-2.5.5 branch July 24, 2024 19:15
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants