-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Logo Generator: open logo generator modal when logo block extension is clicked #38491
AI Logo Generator: open logo generator modal when logo block extension is clicked #38491
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything worked as described.
A couple thoughts:
- I got a single request subtracted from my tier, is that from the first enhanced prompt?
- edgy case, if the above is true: I'm super happy with AI and I have 10 requests left. So I think "oh, ok, I'll save these last 10 for a logo", but when I open the modal, suddenly, I don't have enough requests since I now only have 9 (1 was used to enhance the prompt)
- while the logo history is kept, with the prompt as image description, the suggested prompt is always the same on modal open. Wondering if we could/should override that with the last (current) logo in view? It's not wrong, but on opening I get the last logo (which is actionable, so, it's the "current" selected logo) with a prompt that might have nothing to do with it (though I can see the prompt I used on the image description)
Fixes #38432.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Setup:
logo-history-SITE_ID
property and, if present, delete it)Testing:
First example:
Another example:
Notes:
placement
value, it will also be handled on a follow up (we have tasks for both on the board)