Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Logo Generator: open logo generator modal when logo block extension is clicked #38491

Merged

Conversation

lhkowalski
Copy link
Contributor

@lhkowalski lhkowalski commented Jul 23, 2024

Fixes #38432.

Proposed changes:

  • When the block extension button is clicked, trigger the logo generator modal

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Setup:

  • Enable beta extensions
  • Make sure your testing site has a name and a description; you can set it on WP-Admin, on the Settings menu
  • Clean your site's logo generation history on the local storage (look for a logo-history-SITE_ID property and, if present, delete it)
  • Add a paid Jetpack AI plan to your site, if it does not have one yet (see the notes at the end of the instructions to understand why)

Testing:

  • Go to block editor and insert a site logo block
  • Look for the AI extension on the logo block toolbar and click it
Screenshot 2024-07-23 at 18 04 44
  • Confirm the logo generator modal will show up
  • On the first time opening the tool:
    • confirm it will start generating the first logo automatically
    • confirm your site name and description are taken into account while generating the first option

First example:

Request containing site info Site info present on the prompt
Screenshot 2024-07-23 at 18 01 30 Screenshot 2024-07-23 at 18 02 40

Another example:

Request containing site info Site info present on the prompt
Screenshot 2024-07-23 at 18 11 34 Screenshot 2024-07-23 at 18 12 02
  • Confirm you can generate more logos by typing a prompt on the proper field
Screenshot 2024-07-23 at 18 03 38
  • Confirm you can close the modal and open it again; when doing it:
    • confirm you see the logo generation history
    • confirm you can keep generating logos as long as you have requests available
  • Do the test on a Simple site as well

Notes:

  • the "Use on site" button is not working yet, it will be handled on a follow up
  • the track events being fired may have the wrong placement value, it will also be handled on a follow up (we have tasks for both on the board)
  • the tool will not work for sites on the free plan; there is a check that will show a small message when the site is free, this is the original business decision from Calypso, I plan to remove it on a follow up since we can allow free users to generate images, as long as they have enought requests on the balance

@lhkowalski lhkowalski self-assigned this Jul 23, 2024
@lhkowalski lhkowalski requested a review from a team July 23, 2024 20:39
@lhkowalski lhkowalski added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 23, 2024
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-connect-logo-generator-to-block-extension branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-connect-logo-generator-to-block-extension
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@lhkowalski lhkowalski marked this pull request as ready for review July 23, 2024 21:21
@lhkowalski lhkowalski added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jul 23, 2024
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything worked as described.

A couple thoughts:

  • I got a single request subtracted from my tier, is that from the first enhanced prompt?
  • edgy case, if the above is true: I'm super happy with AI and I have 10 requests left. So I think "oh, ok, I'll save these last 10 for a logo", but when I open the modal, suddenly, I don't have enough requests since I now only have 9 (1 was used to enhance the prompt)
  • while the logo history is kept, with the prompt as image description, the suggested prompt is always the same on modal open. Wondering if we could/should override that with the last (current) logo in view? It's not wrong, but on opening I get the last logo (which is actionable, so, it's the "current" selected logo) with a prompt that might have nothing to do with it (though I can see the prompt I used on the image description)

:shipit:

@lhkowalski lhkowalski merged commit 7b777bd into trunk Jul 24, 2024
58 checks passed
@lhkowalski lhkowalski deleted the update/jetpack-ai-connect-logo-generator-to-block-extension branch July 24, 2024 18:24
@github-actions github-actions bot added this to the jetpack/13.7 milestone Jul 24, 2024
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Logo Generator: Extend the logo block to add the AI button on the toolbar
2 participants