Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version checks: update wording to be more direct #38509

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 24, 2024

Proposed changes:

Let's try to be more direct, avoid "might", so folks feel more confident to run the tools when necessary.

See discussion here:
p1721792055521929-slack-CDLH4C1UZ

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Not much to test here, check the wording.

See discussion here:
p1721792055521929-slack-CDLH4C1UZ
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal [Tools] Monorepo Setup labels Jul 24, 2024
@jeherve jeherve requested a review from a team July 24, 2024 17:09
@jeherve jeherve self-assigned this Jul 24, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@anomiex anomiex merged commit ebbe12b into trunk Jul 25, 2024
55 checks passed
@anomiex anomiex deleted the update/messaging-versioning-fix branch July 25, 2024 16:06
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jul 25, 2024
jeherve added a commit that referenced this pull request Aug 14, 2024
This is a follow-up to #38509, following discussions here:
p1723563421311809/1723563375.969809-slack-C4GAQ900P

Let's try to be more clear that this has to be done by the PR author, before the PR can be merged, so the CI check can pass.
jeherve added a commit that referenced this pull request Aug 14, 2024
This is a follow-up to #38509, following discussions here:
p1723563421311809/1723563375.969809-slack-C4GAQ900P

Let's try to be more clear that this has to be done by the PR author, before the PR can be merged, so the CI check can pass.
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
This is a follow-up to #38509, following discussions here:
p1723563421311809/1723563375.969809-slack-C4GAQ900P

Let's try to be more clear that this has to be done by the PR author, before the PR can be merged, so the CI check can pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Tools] Monorepo Setup [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants