Admin Bar: Fix the order of the top-right items on Atomic sites

[fushar]

Fixes https://github.com/Automattic/dotcom-forge/issues/8443

Proposed changes:

Timeline of events:

1. We updated WordPress on Simple Sites to 6.6.
2. It contains a bug which messed up the admin bar menus.
3. We hotfixed that here.
4. Core released a "fix" here.
   • the fix does not fully restore the original behavior seen in older versions.
5. We updated WordPress on Atomic sites to 6.6.1, containing the above Core fix.
6. Our hotfix from before does not apply, so we need to actually fix the order of items (in this PR).
   • we need to hotfix our previous hotfix on Simple class to ensure that the help center icon is in correct location.

Type	Before	After
Simple
Atomic

Note

I did not try to fix the order of the Debug menu, as it comes from our internal company proxy plugin...

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

1. Test all the scenarios above.
2. Verify that you can still see the help center icon!
3. Test also site frontend; make sure the search icon is still at the top-rightmost (ignoring the Debug menu).

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix-admin-bar-order branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix-admin-bar-order
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[fushar]

This comment shouldn't be relevant anymore, as we no longer load the masterbar class in #38419...

[DustyReagan]

Looks good!
Simple site with this PR:

Atomic sites

Before	After