Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: Fix icon overlap issue at smaller resolutions #38551

Merged
merged 11 commits into from
Aug 1, 2024

Conversation

lupus2k
Copy link
Contributor

@lupus2k lupus2k commented Jul 25, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8378

Proposed changes:

Fix icon overlap issue at smaller resolutions matching Calypso fix

  • Below 480px, I reduced the width of icons in masterbar down to 46px to make more space
  • Below 480px I hid the "+" icon
  • Below 360px I hide the reader icon

Important

Some icons on the right panel could show in different places (related to https://github.com/Automattic/dotcom-forge/issues/8443)

Desktop

WP-Admin image
Calypso image

<780px

WP-Admin image
Calypso image

<480px

WP-Admin image
Calypso image

<360px

WP-Admin image
Calypso image

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

@lupus2k lupus2k self-assigned this Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/icons-width-in-mobile branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/icons-width-in-mobile
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@lupus2k lupus2k force-pushed the fix/icons-width-in-mobile branch from 96f3e11 to 6dcc539 Compare July 26, 2024 13:39
@lupus2k lupus2k marked this pull request as ready for review July 26, 2024 17:47
@lupus2k lupus2k requested review from a team July 26, 2024 17:48
okmttdhr
okmttdhr previously approved these changes Jul 29, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that at certain resolution, e.g. 950px, the help center disappears; can we check?

image

@lupus2k lupus2k requested review from fushar and okmttdhr July 29, 2024 14:58
@lupus2k lupus2k enabled auto-merge (squash) July 29, 2024 14:58
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On site frontend, the left margin of the W logo is too small now for <480px resolution:

image

@fushar
Copy link
Contributor

fushar commented Jul 30, 2024

I pushed a small refactor (ff79eab) but didn't fix the issues above.

Remaining issues:

  • Help center disappearing on < 960px resolution (but might not be related to this PR?)
  • W logo has too small left margin on site frontend

@fushar
Copy link
Contributor

fushar commented Aug 1, 2024

Fixed the site frontend issue; now the W logo is placed correctly:

image

@lupus2k lupus2k merged commit 9767fc7 into trunk Aug 1, 2024
54 checks passed
@lupus2k lupus2k deleted the fix/icons-width-in-mobile branch August 1, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants