Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpcomsh: COLOURlovers: Remove Temporary Patterns Tracking #38568

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Jul 26, 2024

Proposed changes:

  • Removes temporary tracking of COLOURlovers pattern usage added 3 months ago.
  • See: PR 1819 on the old wpcomsh repo + pdKhl6-3qP-p2#comment-7087

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Verify no references to wpcomsh_temporarily_maybe_track_colourlovers_pattern_usage remain
  • Basic tests

@mreishus mreishus changed the title COLOURlovers: Add Temporary Patterns Tracking COLOURlovers: Remove Temporary Patterns Tracking Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 26, 2024
@mreishus mreishus added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 26, 2024
@mreishus mreishus changed the title COLOURlovers: Remove Temporary Patterns Tracking wpcomsh: COLOURlovers: Remove Temporary Patterns Tracking Jul 26, 2024
@mreishus mreishus force-pushed the remove/wpcomsh-colourlovers-tracking branch from 0126ef9 to a3d423a Compare July 30, 2024 18:27
@mreishus
Copy link
Contributor Author

  • rebased

@mreishus mreishus merged commit 61cdd72 into trunk Jul 30, 2024
53 checks passed
@mreishus mreishus deleted the remove/wpcomsh-colourlovers-tracking branch July 30, 2024 18:36
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants